On 16.01.23 07:01, Srivatsa S. Bhat wrote:
From: "Srivatsa S. Bhat (VMware)" <[email protected]>Under hypervisors that support mwait passthrough, a vCPU in mwait CPU-idle state remains in guest context (instead of yielding to the hypervisor via VMEXIT), which helps speed up wakeups from idle. However, this runs into problems with CPU hotplug, because the Linux CPU offline path prefers to put the vCPU-to-be-offlined in mwait state, whenever mwait is available. As a result, since a vCPU in mwait remains in guest context and does not yield to the hypervisor, an offline vCPU *appears* to be 100% busy as viewed from the host, which prevents the hypervisor from running other vCPUs or workloads on the corresponding pCPU. [ Note that such a vCPU is not actually busy spinning though; it remains in mwait idle state in the guest ]. Fix this by preventing the use of mwait idle state in the vCPU offline play_dead() path for any hypervisor, even if mwait support is available. Suggested-by: Peter Zijlstra (Intel) <[email protected]> Signed-off-by: Srivatsa S. Bhat (VMware) <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Borislav Petkov <[email protected]> Cc: Dave Hansen <[email protected]> Cc: "H. Peter Anvin" <[email protected]> Cc: "Rafael J. Wysocki" <[email protected]> Cc: "Paul E. McKenney" <[email protected]> Cc: Wyes Karny <[email protected]> Cc: Lewis Caroll <[email protected]> Cc: Tom Lendacky <[email protected]> Cc: Alexey Makhalov <[email protected]> Cc: Juergen Gross <[email protected]> Cc: [email protected] Cc: VMware PV-Drivers Reviewers <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected]
Reviewed-by: Juergen Gross <[email protected]> Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
_______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
