RE: [PATCH v2 1/3] virtio_pci_modern: Allow non power of 2 sizes for virtqueues

[Parav Pandit via Virtualization]

> From: Feng Liu <fe...@nvidia.com>
> Sent: Friday, March 10, 2023 12:34 AM

> 
> -     if (!is_power_of_2(num)) {
> -             dev_warn(&vp_dev->pci_dev->dev, "bad queue size %u",
> num);
> -             return ERR_PTR(-EINVAL);
> -     }
> -

The check is still valid for split q.
Maybe the right place for such a check is not the pci transport driver.
But layer below where split vs packed q knowledge resides and hence, power of 2 
check can be omitted for packed vq.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization