On 06/11, Eric W. Biederman wrote:
>
> Oleg Nesterov <o...@redhat.com> writes:
>
> > Could you spell to explain why this can't work (again, in this simple case) 
> > ?
> >
> > My current (and I know, very poor) understanding is that .release() should
> > roughly do the following:
> >
> >     1. Ensure that vhost_work_queue() can't add the new callbacks
> >
> >     2. Call vhost_dev_flush() to ensure that worker->work_list is empty
> >
> >     3. Call vhost_task_stop()
>
> At least in the case of exec by the time the final fput happens
> from close_on_exec the task has already changed it's mm.

Of course you are right.

But can't resist, please note that I only meant "this simple case" which
doesn't include exec/etc.

Nevermind. As Mike explains there are more problems even in this particular
"simple" case, and I am not surprised.

Sorry for noise,

Oleg.

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Reply via email to