On Tue, Sep 26, 2023 at 01:00:20PM +0800, liming...@jaguarmicro.com wrote:
> From: Liming Wu <liming...@jaguarmicro.com>
>
> Need to insmod vhost_test.ko before run virtio_test.
> Give some hints to users.
>
> Signed-off-by: Liming Wu <liming...@jaguarmicro.com>
> ---
> tools/virtio/virtio_test.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
> index 028f54e6854a..ce2c4d93d735 100644
> --- a/tools/virtio/virtio_test.c
> +++ b/tools/virtio/virtio_test.c
> @@ -135,6 +135,10 @@ static void vdev_info_init(struct vdev_info* dev,
> unsigned long long features)
> dev->buf = malloc(dev->buf_size);
> assert(dev->buf);
> dev->control = open("/dev/vhost-test", O_RDWR);
> +
> + if (dev->control < 0)
> + fprintf(stderr, "Install vhost_test module" \
> + "(./vhost_test/vhost_test.ko) firstly\n");
Thanks!
things to improve:
firstly -> first
add space before (
End sentence with a dot
align "" on the two lines
> assert(dev->control >= 0);
> r = ioctl(dev->control, VHOST_SET_OWNER, NULL);
> assert(r >= 0);
> --
> 2.34.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
