On Thu 22-08-24 17:44:22, Linus Torvalds wrote: [...] > And dammit, those kvmalloc() sizes need to be limited too. A number > like 24kB was mentioned. That sounds fine. Maybe even 64kB. But make > it *SMALL*.
I am not particularly bothered by exact size for kvmalloc. There should be a limit all right, but whether that is 1MB or 64kB shouldn't make much of a difference because we do use 4kB pages to back those allocations anyway. Sure 32b is a different story because the vmalloc space itself is a scarce resource but do we care about those? > And make it clear that it will return NULL if somebody misuses it. What do you expect users do with the return value then? -- Michal Hocko SUSE Labs
