Acked-by: Zhu Lingshan <lingshan....@kernel.org>
Yuan Can <yuan...@huawei.com> 于2024年10月17日周四 09:42写道：
>
> ifcvf_init_hw() uses pci_read_config_byte() that returns
> PCIBIOS_* codes. The error handling, however, assumes the codes are
> normal errnos because it checks for < 0.
> Convert the error check to plain non-zero check.
>
> Fixes: 5a2414bc454e ("virtio: Intel IFC VF driver for VDPA")
> Signed-off-by: Yuan Can <yuan...@huawei.com>
> ---
> drivers/vdpa/ifcvf/ifcvf_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/ifcvf/ifcvf_base.c b/drivers/vdpa/ifcvf/ifcvf_base.c
> index 472daa588a9d..d5507b63b6cd 100644
> --- a/drivers/vdpa/ifcvf/ifcvf_base.c
> +++ b/drivers/vdpa/ifcvf/ifcvf_base.c
> @@ -108,7 +108,7 @@ int ifcvf_init_hw(struct ifcvf_hw *hw, struct pci_dev
> *pdev)
> u32 i;
>
> ret = pci_read_config_byte(pdev, PCI_CAPABILITY_LIST, &pos);
> - if (ret < 0) {
> + if (ret) {
> IFCVF_ERR(pdev, "Failed to read PCI capability list\n");
> return -EIO;
> }
> --
> 2.17.1
>
