> From: Jason Gunthorpe <j...@nvidia.com> > Sent: Thursday, July 3, 2025 9:41 PM > > On Thu, Jul 03, 2025 at 06:40:48AM +0000, Tian, Kevin wrote: > > > From: Jason Gunthorpe <j...@nvidia.com> > > > Sent: Wednesday, June 25, 2025 2:35 AM > > > > > > @@ -1583,6 +1583,7 @@ static const struct vfio_device_ops > > > hisi_acc_vfio_pci_ops = { > > > .mmap = vfio_pci_core_mmap, > > > .request = vfio_pci_core_request, > > > .match = vfio_pci_core_match, > > > + .match_token_uuid = vfio_pci_core_match_token_uuid, > > > > this matters only when the driver supports SR-IOV. currently only > > vfio-pci does. > > Hmm, sriov_pf_core_dev requires sriov_config, but the normal vf_token > happens for all vfs and there is a little debugging related to it: > > pci_info_ratelimited(vdev->pdev, > "VF token incorrectly provided, PF not bound > to vfio-pci\n"); > > So maybe we want to keep it. Otherwise it sounds like you are > proposing to remove match from most of the drivers since they don't > support sriov_configure? Which ever direction I think match and > match_token_uuid should be together. >
Okay that makes sense.