On Sun, Jan 25, 2026 at 03:10:32PM +0100, Francesco Valla wrote: > Hi Matias, > > If an additional version is foreseen, consider dropping some more > note-like comments, as in future they might become dangling. >
Yes! I am planing to remove some comments and send v9. I was not completely sure which ones. Also, I was thinking to set myself as a maintainer in case Harald is busy. > E.g.: > > On Tue, Jan 20, 2026 at 07:05:38PM +0100, Matias Ezequiel Vara Larsen wrote: > > [...] > > > + > > +/* Poll TX used queue for sent CAN messages > > + * See https://wiki.linuxfoundation.org/networking/napi function > > + * int (*poll)(struct napi_struct *napi, int budget); > > + */ > > +static int virtio_can_tx_poll(struct napi_struct *napi, int quota) > > +{ > > [...] > > > +/* See m_can_poll() / m_can_handle_state_errors() > > m_can_handle_state_change() */ > > +static int virtio_can_handle_busoff(struct net_device *dev) > > +{ > > [...] > > > +/* Poll RX used queue for received CAN messages > > + * See https://wiki.linuxfoundation.org/networking/napi function > > + * int (*poll)(struct napi_struct *napi, int budget); > > + * Important: "The networking subsystem promises that poll() will not be > > + * invoked simultaneously (for the same napi_struct) on multiple > > processors" > > + */ > > +static int virtio_can_rx_poll(struct napi_struct *napi, int quota) > > +{ > > + > > [...] > > > +/* Compare with m_can.c/m_can_suspend(), virtio_net.c/virtnet_freeze() and > > + * virtio_card.c/virtsnd_freeze() > > + */ > > +static int __maybe_unused virtio_can_freeze(struct virtio_device *vdev) > > +{ > > [...] > > + > > +/* Compare with m_can.c/m_can_resume(), virtio_net.c/virtnet_restore() and > > + * virtio_card.c/virtsnd_restore() > > + */ > > +static int __maybe_unused virtio_can_restore(struct virtio_device *vdev) > > +{ > > > With this (maybe negligible) note considered: > > Reviewed-by: Francesco Valla <[email protected]> > Tested-by: Francesco Valla <[email protected]> > Thanks Francesco! Matias
