Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dt-bindings: spi-virtio: undocumented compatible in example --
commit eb6ae8a9a8b3aa403347f70589897a8c7d297186 Author: Francesco Valla <[email protected]> dt-bindings: spi: add bindings for spi-virtio This commit adds device tree bindings for spi-virtio based on virtio-device. It defines the properties and node dependencies for the virtio SPI controller. > diff --git a/Documentation/devicetree/bindings/spi/spi-virtio.yaml > b/Documentation/devicetree/bindings/spi/spi-virtio.yaml > new file mode 100644 > index 0000000000000..5b8639dd2e1f1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/spi-virtio.yaml [ ... ] > +examples: > + - | > + virtio@3000 { > + compatible = "virtio,mmio"; > + reg = <0x3000 0x100>; > + interrupts = <41>; > + > + spi { > + compatible = "virtio,device2d"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + sram@0 { > + compatible = "microchip,mchp23k256"; [Severity: Low] Is this compatible string documented in any existing binding schema? The dt_binding_check tool strictly validates all compatible strings against known schemas, so an undocumented compatible string in an example will emit a schema validation warning. When running make dt_binding_check on the new spi-virtio.yaml file, it parses the example and attempts to match microchip,mchp23k256 against registered bindings, which fails if none exist. > + reg = <0>; > + spi-max-frequency = <20000000>; > + }; > + }; > + }; > + > +... -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
