> From: "Denis V. Lunev" <[email protected]> > > [ Upstream commit 198eda395067b56ee605de076f0519620f4e5d90 ] > > tell_host() ignores the return value of virtqueue_add_outbuf() and goes > on to kick the queue and wait_event() for the host's ack. The comment > claims "We should always be able to add one buffer to an empty queue", > but that does not hold once the virtqueue has been broken (e.g. on > device shutdown): the add then fails with -EIO and the following > wait_event() would block forever on a buffer the host can never return. > > Warn and bail out on failure, mirroring virtballoon_free_page_report(). > > Suggested-by: David Hildenbrand <[email protected]> > Signed-off-by: Denis V. Lunev <[email protected]> > Signed-off-by: Michael S. Tsirkin <[email protected]> > Message-ID: <[email protected]> > Signed-off-by: Sasha Levin <[email protected]>
Sashiko has reviewed this patch and found no issues. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
