Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] virtio-mem: missing kernel-parameters.txt entry for virtio_mem.memmap_on_memory --
commit 20926ca463fbc5ddc5964493d1dbdfa119302f38 Author: Nikolaos Karaolidis <[email protected]> virtio-mem: support memmap_on_memory in Big Block Mode This commit adds a virtio_mem.memmap_on_memory module parameter to enable self-hosted memmaps via MHP_MEMMAP_ON_MEMORY when operating in Big Block Mode, and skips the memmap pages during fake-offlining and rollback. > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index ab06adbc0342b..034d07207e44d 100644 > --- a/drivers/virtio/virtio_mem.c > +++ b/drivers/virtio/virtio_mem.c > @@ -40,6 +40,11 @@ module_param(bbm_block_size, ulong, 0444); > MODULE_PARM_DESC(bbm_block_size, > "Big Block size in bytes. Default is 0 (auto-detection)."); > > +static bool memmap_on_memory; > +module_param(memmap_on_memory, bool, 0444); > +MODULE_PARM_DESC(memmap_on_memory, > + "Allocate the memmap from hotplugged memory itself if > memory_hotplug.memmap_on_memory is enabled. Default is 0."); [Severity: Low] drivers/virtio/virtio_mem.c registers the new memmap_on_memory module parameter with 0444 permissions, which can be passed on the kernel command line at boot as virtio_mem.memmap_on_memory=. Should Documentation/admin-guide/kernel-parameters.txt also be updated to document virtio_mem.memmap_on_memory, its format, what it controls, and the architectures it applies to? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=3
