Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] ALSA: virtio: commit message omits DMA page pinning and RX completion checks --
commit 832b53a386769dc75553162a208f16a9eb5a42b0 Author: Joonho Lee <[email protected]> > ALSA: virtio: validate indirect PCM ACK accounting > > Validate playback appl_ptr accounting before the indirect transfer > helper can mutate its cursor or queue data. Normalize boundary wrap, > reject frame deltas outside runtime->min_align before byte conversion, > and check frame-to-byte geometry before the helper's signed multiply. > Validate ring indices and signed ready counters, then bound hw_ready + > sw_ready + new bytes by the PCM buffer capacity. The playback pointer > has already deducted device completions from hw_ready when ACK runs. > > Retain ordinary indirect capture's existing checks against unread > completed RX bytes and its pre-START no-data behavior. An invalid paused > playback ACK returns -EBADFD without starting a linked XRUN. > > Assisted-by: LLM > Signed-off-by: Joonho Lee <[email protected]> [Severity: Low] This isn't a bug, but the commit title and message only describe the indirect playback and capture ACK validation in sound/virtio/virtio_pcm_ops.c. They do not mention the other changes in this patch: retaining struct page references for vmalloc PCM buffers via virtsnd_pcm_dma_pages_get() and virtsnd_pcm_dma_pages_put() (and allocating owned_dma_area on !CONFIG_MMU), rewriting capture completion validation and xfer_xrun handling in virtsnd_pcm_msg_complete(), checking offset and byte bounds in virtsnd_pcm_msg_send(), and checking period and buffer alignment in virtsnd_pcm_hw_params(). Could the changelog be updated (or the patch split) to cover these changes? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=8
