Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] net: skbuff: missing Fixes trailers for skb_frag_ref() and iptfs fixes --
commit 289785b15a220a700e7ce94d6b9993ab94b82d49 Author: Mina Almasry <[email protected]> > net: skbuff: skip managed zerocopy frags in skb_frag_ref() > > skb_frag_unref() and skb_release_data() skip releasing references on > managed zerocopy fragments (SKBFL_MANAGED_FRAG_REFS), whereas > skb_frag_ref() acquires a reference unconditionally. If skb_frag_ref() > is called on a managed zerocopy SKB, the acquired reference is never > released by skb_frag_unref() or skb_release_data(). > > Skip acquiring a reference in skb_frag_ref() when skb_zcopy_managed(skb) > is true so skb_frag_ref() matches skb_frag_unref() and > skb_release_data(), and disable share_ok in iptfs_output_queued() when > skb_zcopy_managed(skb) is true so iptfs_consume_frags() does not append > unreferenced fragments into a managed zerocopy outer SKB. > > Signed-off-by: Mina Almasry <[email protected]> [Severity: Low] Since this fixes fragment reference accounting for SKBFL_MANAGED_FRAG_REFS in skb_frag_ref() and fragment sharing in iptfs_output_queued(), should the commit message include: Fixes: 753f1ca4e1e5 ("net: introduce managed frags infrastructure") Fixes: b96ba312e21c ("xfrm: iptfs: share page fragments of inner packets") -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
