On Mon, Nov 09, 2026 at 12:34:55PM +0000, [email protected] wrote: > [Severity: Low] > > Is explicit XDP removal followed by closing the socket the only trigger? > > Ordinary netdev unregistration looks like it ends in the same failed > disable. Examples are virtio-net hot-unplug, driver unbind and module > unload.
[ ... ] > The new max_queue_pairs bound fixes this path as well. The commit message > only hints at it with "Removing XDP must not fail". Could the message > also mention the unregister path? Yes. Unbinding the device from virtio_net with XDP attached and a socket bound to an XDP queue gives "Failed to disable zero-copy!" without this patch and no warning with it. I'll mention that path in the changelog. > [Severity: Medium] > > How does this wider qid range interact with the restore fallback that a > later patch in this series adds to this function? [ ... ] > Does this leak the xsk_dma_map, its dma_pages array and the DMA or IOMMU > mappings of the umem pages? It does, but only together with the restore fallback of patch 3, which looks the pool up with xsk_get_pool_from_qid(). Patch 3 has other problems for pools above curr_queue_pairs too, so I'll drop it from the series and resend patches 1 and 2 as v3. The reworked patch 3 will keep track of the pools in the driver instead of looking them up by queue id. pw-bot: cr
