Le Mardi, 25 Juillet 2006 18.46, Arne Brutschy a écrit :
> Hi Nicolas,
>
> I got a short question regarding your patch:
>
> N> here's a patch for both problems (notifier_* in modules/core/core_main.c
> and N> flip in vgms/card.c) :
> [..]
> N> - return notifier_chain_register(&visdn_notify_chain, nb);
> N> + visdn_notify_chain_head.head = visdn_notify_chain;
> N> + return
> N> raw_notifier_chain_register(&visdn_notify_chain_head, nb);
> You solved this differently than I did. Was my version wrong? What's
> the reason for the line "visdn_notify_chain_head.head =
> visdn_notify_chain;" ?
>
Hmmm, I missed your patch when I posted mine - otherwise I wouldn't have
bothered :=)
I did it this way because, when I looked at notifier.h in kernel includes, I
saw that the function raw_notifier_chain_register() took as 1st arg a struct
of type raw_notifier_head, defined as follow:
struct raw_notifier_head {
struct notifier_block *head;
};
and feared that, doing it your way would generate a compile-time warning i.e
"type mismatch". It's functionaly equivalent, tho, since the struct has only
1 var.
But I must say that your patch looks cleaner than mine ;-)
--
Nicolas Ouedraogo
Associate
SwissVON s.a.r.l
rue Michel-Chauvet 3
CH-1208 Geneva
Switzerland
sip: [EMAIL PROTECTED]
tel.: +41 (22) 347-2137
fax: +41 (22) 328-2626
_______________________________________________
Visdn-hackers mailing list
[email protected]
https://mailman.uli.it/mailman/listinfo/visdn-hackers
