Matthias Urlichs ha scritto:
> Hi, Massimo Nuvoli wrote:
>
>> This patch corrects a lot of possibile "segmentation fault" in the code.
> Umm... what's this:
> if (!ast_chan)
> + {
> + ast_log(LOG_WARNING, "Unexpexted ast_chan NULL\n");
> return;
> + }
>
> ast_mutex_lock(&ast_chan->lock);
> +
> + if (!ast_chan)
> + {
> + ast_log(LOG_WARNING, "Unexpexted ast_chan NULL\n");
> + return;
> + }
> The second hunk, testing ast_chan again after ast_mutex_lock(), does make
> no sense whatsoever. You have a few other places where you do this.I found sometime after the mutex lock the ast_chan is NULL. I think while stopped by the mutex the chan is closed so this is the cause. Maybe i am wrong.. :-) > - if (module->tty->flip.count >= > + if (module->tty->max_flip_cnt >= > Shouldn't that depend on the kernel version? max_flip_cnt actually seems > to be unused (i.e. always zero) in the current (v2.6.18rc2) kernel. Shure this is for the "kernel" version i use (2.6.16-2). Bye.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Visdn-hackers mailing list [email protected] https://mailman.uli.it/mailman/listinfo/visdn-hackers
