Hello,

first of all, I want to thank Daniele for coming back. I know how hard
it is, rewriting the core of a software and in the middle neither the
old nor the new code works anymore. And all you ask yourself is if
you're able to clean up the mess you're done. So I'm glad you made
it... :)

Nevertheless, I think it is strongly needed to open up visdn
development. I think the community has done some patches, has error
reports etc.. So let's start making visdn better!

I start by submitting the usual visdn-for-new-kernel-versions patch...
There's been some API changes since 2.6.16, and this patch makes the
appropriate changes.

Daniele, can you review the patches and perhaps include them in the
codebase? It would be nice to have visdn compile on new kernels out of
the box...

Please test it, as the vgsm stuff isn't available to me.

Regards,
Arne


List of changes:
----------------

modules/core/core_main.c
  Fixes:
    CC [M]  visdn-0.18.3/modules/core/core_main.o
    visdn-0.18.3/modules/core/core_main.c: In function 
‘visdn_register_notifier’:
    visdn-0.18.3/modules/core/core_main.c:80: warning: implicit declaration of 
function ‘notifier_chain_register’
    visdn-0.18.3/modules/core/core_main.c: In function 
‘visdn_unregister_notifier’:
    visdn-0.18.3/modules/core/core_main.c:86: warning: implicit declaration of 
function ‘notifier_chain_unregister’
    visdn-0.18.3/modules/core/core_main.c: In function ‘visdn_call_notifiers’:
    visdn-0.18.3/modules/core/core_main.c:92: warning: implicit declaration of 
function ‘notifier_call_chain’
  Explanation:
    Notifier chain API changed in 2.6.17, see http://lwn.net/Articles/185500/
    Daniele: the raw_* functions will be removed soon, please decide if we need 
to
             use atomic_* or blocking_*

modules/vgsm/vgsm_main.c
  _UNTESTED_ as I don't use the vgsm module
  Fixes:
    visdn-0.18.3/modules/vgsm/vgsm_main.c: In function ‘vgsm_init’:
    visdn-0.18.3/modules/vgsm/vgsm_main.c:604: error: ‘struct tty_driver’ has 
no member named ‘devfs_name’
    visdn-0.18.3/modules/vgsm/vgsm_main.c:609: error: ‘TTY_DRIVER_NO_DEVFS’ 
undeclared (first use in this function)
  Explanation:
    - tty_driver.devfs_name removed from linux/tty_driver.h in kernel
      2.6.18 see http://lkml.org/lkml/2005/6/21/46
    - TTY_DRIVER_NO_DEVFS renamed to TTY_DRIVER_DYNAMIC_DEV in
      linux/tty_driver.h in kernel 2.6.18 see http://lkml.org/lkml/2005/6/11/20

modules/vgsm/card.c
  _UNTESTED_ as I don't use the vgsm module
  Fixes:
    CC [M]  visdn-0.18.3/modules/vgsm/vgsm_main.o
    CC [M]  visdn-0.18.3/modules/vgsm/card.o
    visdn-0.18.3/modules/vgsm/card.c: In function ‘vgsm_handle_serial_int’:
    visdn-0.18.3/modules/vgsm/card.c:477: error: ‘struct tty_struct’ has no 
member named ‘flip’
  Explanation:
    TTY flip buffer API changed in 2.6.16,
    see http://www.kernel.org/pub/linux/kernel/v2.6/ChangeLog-2.6.16
    Please note that previous patches concering the flip.count are
    bogus.















Attachment: visdn-0.18.3_kernel-2.6.16+.patch
Description: Binary data

_______________________________________________
Visdn-hackers mailing list
[email protected]
https://mailman.uli.it/mailman/listinfo/visdn-hackers

Reply via email to