vlc | branch: master | Felix Paul Kühne <[email protected]> | Sat Feb 18 01:37:26 2012 +0100| [32113d105ce810b0e2c3da3e923e0be1bff35be0] | committer: Felix Paul Kühne
Revert "macosx: prevent unwanted strings from being displayed instead of empty strings as suggested by xtophe" This reverts commit a97666db8a5ee0eb8498cc068c4fe3a8d76e1783. > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=32113d105ce810b0e2c3da3e923e0be1bff35be0 --- modules/gui/macosx/prefs.m | 9 +-------- modules/gui/macosx/simple_prefs.m | 14 +------------- 2 files changed, 2 insertions(+), 21 deletions(-) diff --git a/modules/gui/macosx/prefs.m b/modules/gui/macosx/prefs.m index 11eb51a..dc91a39 100644 --- a/modules/gui/macosx/prefs.m +++ b/modules/gui/macosx/prefs.m @@ -478,20 +478,13 @@ static VLCPrefs *_o_sharedMainInstance = nil; @implementation VLCTreePluginItem - (id)initWithPlugin:(module_t *)plugin { - const char * psz_name = module_get_name( plugin, false ); - NSString * name; - if (psz_name) - name = _NS(psz_name); - else - name = @""; - + NSString * name = _NS( module_get_name( plugin, false )?:"" ); if(self = [super initWithName:name]) { _configItems = module_config_get( plugin, &_configSize ); //_plugin = plugin; //_help = [_NS(config_CategoryHelpGet( subCategory )) retain]; } - return self; } diff --git a/modules/gui/macosx/simple_prefs.m b/modules/gui/macosx/simple_prefs.m index 0f91f5a..cd00aba 100644 --- a/modules/gui/macosx/simple_prefs.m +++ b/modules/gui/macosx/simple_prefs.m @@ -438,19 +438,7 @@ static inline char * __config_GetLabel( vlc_object_t *p_this, const char *psz_na - (void)setupButton: (NSButton *)object forBoolValue: (const char *)name { [object setState: config_GetInt( p_intf, name )]; - - char * psz_label = config_GetLabel( p_intf, name ); - NSString * o_label; - - if (psz_label) - { - o_label = _NS(psz_label); - free( psz_label ); - } - else - o_label = @""; - - [object setToolTip: o_label]; + [object setToolTip: _NS(config_GetLabel( p_intf, name ) ?: "")]; } - (void)setupField:(NSTextField *)o_object forOption:(const char *)psz_option _______________________________________________ vlc-commits mailing list [email protected] http://mailman.videolan.org/listinfo/vlc-commits
