vlc | branch: master | Rémi Denis-Courmont <[email protected]> | Tue Nov 6 19:33:29 2012 +0200| [0e893017b73a97f155a8f43db5c37ca0d8b385f8] | committer: Rémi Denis-Courmont
audiobargraph: setup filter_t only when successful > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0e893017b73a97f155a8f43db5c37ca0d8b385f8 --- modules/audio_filter/audiobargraph_a.c | 24 +++++------------------- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/modules/audio_filter/audiobargraph_a.c b/modules/audio_filter/audiobargraph_a.c index 8c88aa2..6d2978b 100644 --- a/modules/audio_filter/audiobargraph_a.c +++ b/modules/audio_filter/audiobargraph_a.c @@ -130,25 +130,7 @@ struct filter_sys_t static int Open( vlc_object_t *p_this ) { filter_t *p_filter = (filter_t *)p_this; - filter_sys_t *p_sys; - - if ( !AOUT_FMTS_SIMILAR( &p_filter->fmt_in.audio, &p_filter->fmt_out.audio ) ) - { - msg_Err( p_filter, "input and output formats are not similar" ); - return VLC_EGENERIC; - } - - if( p_filter->fmt_in.audio.i_format != VLC_CODEC_FL32 || - p_filter->fmt_out.audio.i_format != VLC_CODEC_FL32 ) - { - p_filter->fmt_in.audio.i_format = VLC_CODEC_FL32; - p_filter->fmt_out.audio.i_format = VLC_CODEC_FL32; - msg_Warn( p_filter, "bad input or output format" ); - } - - p_filter->pf_audio_filter = DoWork; - - p_sys = p_filter->p_sys = malloc( sizeof( *p_sys ) ); + filter_sys_t *p_sys = p_filter->p_sys = malloc( sizeof( *p_sys ) ); if( !p_sys ) return VLC_ENOMEM; @@ -172,6 +154,10 @@ static int Open( vlc_object_t *p_this ) p_sys->started = 0; p_sys->lastAlarm = 0; + p_filter->fmt_in.audio.i_format = VLC_CODEC_FL32; + p_filter->fmt_out.audio = p_filter->fmt_in.audio; + p_filter->pf_audio_filter = DoWork; + return VLC_SUCCESS; } _______________________________________________ vlc-commits mailing list [email protected] http://mailman.videolan.org/listinfo/vlc-commits
