vlc | branch: master | Felix Paul Kühne <[email protected]> | Thu Dec 26 17:34:51 2013 +0100| [4598d6ca9965428938efddc8469ee39cc73443e6] | committer: Felix Paul Kühne
auhal: add missing bounds checking (close #10110) > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=4598d6ca9965428938efddc8469ee39cc73443e6 --- modules/audio_output/auhal.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/modules/audio_output/auhal.c b/modules/audio_output/auhal.c index 9749035..f2d3643 100644 --- a/modules/audio_output/auhal.c +++ b/modules/audio_output/auhal.c @@ -1445,9 +1445,11 @@ static OSStatus RenderCallbackAnalog(vlc_object_t *p_obj, } else { int32_t bytesToCopy = __MIN(bytesRequested, availableBytes); - memcpy(targetBuffer, buffer, bytesToCopy); - TPCircularBufferConsume(&p_sys->circular_buffer, bytesToCopy); - ioData->mBuffers[0].mDataByteSize = bytesToCopy; + if (likely(bytesToCopy > 0)) { + memcpy(targetBuffer, buffer, bytesToCopy); + TPCircularBufferConsume(&p_sys->circular_buffer, bytesToCopy); + ioData->mBuffers[0].mDataByteSize = bytesToCopy; + } } vlc_cond_signal(&p_sys->cond); _______________________________________________ vlc-commits mailing list [email protected] https://mailman.videolan.org/listinfo/vlc-commits
