vlc/vlc-3.0 | branch: master | David Fuhrmann <dfuhrm...@videolan.org> | Sat 
Mar 24 16:53:35 2018 +0100| [1a5482c3d82f4ad398705db42e71cda663dc7c23] | 
committer: David Fuhrmann

macOS build.sh: Workaround for breakpad symbol generation

Current tools set the library identification names to the
unversioned libraries (e.g. rpath/libvlccore.dylib), therefore
breakpad needs symbols with that library name.
Currently, breakpad does not support having the same symbols for
multiple names, therefore it cannot keep symbols for both the
versioned and unversioned variants.

Workaround that by removing the symlinks and only keeping the
unversioned name of the libraries for VLC-debug.app.

refs #19653

(cherry picked from commit f006b0e462b8a2a77a108d174cf2af6dee58f392)
Signed-off-by: David Fuhrmann <dfuhrm...@videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-3.0.git/?a=commit;h=1a5482c3d82f4ad398705db42e71cda663dc7c23
---

 extras/package/macosx/build.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/extras/package/macosx/build.sh b/extras/package/macosx/build.sh
index 5b2402a9ed..8d618e0e6c 100755
--- a/extras/package/macosx/build.sh
+++ b/extras/package/macosx/build.sh
@@ -294,6 +294,12 @@ if [ "$PACKAGETYPE" = "u" ]; then
     rm -rf VLC-debug.app
     cp -Rp VLC.app VLC-debug.app
 
+    # Workaround for breakpad symbol parsing:
+    # Symbols must be uploaded for libvlc(core).dylib, not libvlc(core).x.dylib
+    (cd VLC-debug.app/Contents/MacOS/lib/ && rm libvlccore.dylib && mv 
libvlccore.*.dylib libvlccore.dylib)
+    (cd VLC-debug.app/Contents/MacOS/lib/ && rm libvlc.dylib && mv 
libvlc.*.dylib libvlc.dylib)
+
+
     find VLC.app/ -name "*.dylib" -exec strip -x {} \;
     find VLC.app/ -type f -name "VLC" -exec strip -x {} \;
     find VLC.app/ -type f -name "Sparkle" -exec strip -x {} \;

_______________________________________________
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits

Reply via email to