Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC
Commits: 94df8690 by Romain Vimont at 2021-10-16T08:09:26+00:00 opengl: renderer: do not enable GL_CULL_FACE The OpenGL states must not be set on Open, but on each Draw call if necessary (they may impact other filters). In practice, it is not necessary to set them at all: - GL_CULL_FACE is useless for the renderer; - the other states are assumed to be the default values in all other filters. Suggested-by: Niklas Haas <[email protected]> - - - - - 1 changed file: - modules/video_output/opengl/renderer.c Changes: ===================================== modules/video_output/opengl/renderer.c ===================================== @@ -348,13 +348,6 @@ vlc_gl_renderer_Open(struct vlc_gl_filter *filter, getViewpointMatrixes(renderer, fmt->projection_mode); - /* */ - vt->Disable(GL_BLEND); - vt->Disable(GL_DEPTH_TEST); - vt->DepthMask(GL_FALSE); - vt->Enable(GL_CULL_FACE); - vt->ClearColor(0.0f, 0.0f, 0.0f, 1.0f); - vt->GenBuffers(1, &renderer->vertex_buffer_object); vt->GenBuffers(1, &renderer->index_buffer_object); vt->GenBuffers(1, &renderer->texture_buffer_object); View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/94df8690d9810c23500c3ad151e7feb891e15102 -- View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/94df8690d9810c23500c3ad151e7feb891e15102 You're receiving this email because of your account on code.videolan.org.
_______________________________________________ vlc-commits mailing list [email protected] https://mailman.videolan.org/listinfo/vlc-commits
