Hugo Beauzée-Luyssen pushed to branch master at VideoLAN / VLC
Commits:
8af798b9 by Romain Vimont at 2021-11-25T13:37:55+00:00
opengl: log an error on filter loading failed
- - - - -
71955299 by Romain Vimont at 2021-11-25T13:37:55+00:00
opengl: improve error on pl_scale loading error
When pl_scale could not be loaded, explicitly log an error to report
that --gl-upscaler and --gl-downscaler options will be ignored.
- - - - -
2 changed files:
- modules/video_output/opengl/filters.c
- modules/video_output/opengl/vout_helper.c
Changes:
=====================================
modules/video_output/opengl/filters.c
=====================================
@@ -234,6 +234,7 @@ vlc_gl_filters_Append(struct vlc_gl_filters *filters, const
char *name,
if (ret != VLC_SUCCESS)
{
/* Creation failed, do not call close() */
+ msg_Err(filters->gl, "Could not load OpenGL filter '%s'", name);
filter->ops = NULL;
vlc_gl_filter_Delete(filter);
return NULL;
=====================================
modules/video_output/opengl/vout_helper.c
=====================================
@@ -172,7 +172,14 @@ vout_display_opengl_t
*vout_display_opengl_New(video_format_t *fmt,
struct vlc_gl_filter *scale_filter =
vlc_gl_filters_Append(vgl->filters, "pl_scale", &cfg);
if (!scale_filter)
- msg_Warn(gl, "Could not load pl_scale");
+ {
+ if (upscaler)
+ msg_Err(gl, "Could not apply upscaler filter, "
+ "ignoring --gl-upscaler=%d", upscaler);
+ if (downscaler)
+ msg_Err(gl, "Could not apply downscaler filter, "
+ "ignoring --gl-downscaler=%d", downscaler);
+ }
}
/* The renderer is the only filter, for now */
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/compare/6301793c01bfa75c36c7a2afc058f0dda63c52a3...7195529927c75d021a4427becd5119677f8fe0d7
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/compare/6301793c01bfa75c36c7a2afc058f0dda63c52a3...7195529927c75d021a4427becd5119677f8fe0d7
You're receiving this email because of your account on code.videolan.org.
_______________________________________________
vlc-commits mailing list
[email protected]
https://mailman.videolan.org/listinfo/vlc-commits
