Steve Lhomme pushed to branch master at VideoLAN / VLC
Commits:
e052a07d by Claudio Cambra at 2024-12-09T15:59:37+00:00
macosx: Do not present the loading overlay view on top of the video view in the
library window
Signed-off-by: Claudio Cambra <develo...@claudiocambra.com>
- - - - -
9d2479c2 by Claudio Cambra at 2024-12-09T15:59:37+00:00
macosx: Present loading overlay view when quitting video view if loading was
and is still taking place
Signed-off-by: Claudio Cambra <develo...@claudiocambra.com>
- - - - -
1 changed file:
- modules/gui/macosx/library/VLCLibraryWindow.m
Changes:
=====================================
modules/gui/macosx/library/VLCLibraryWindow.m
=====================================
@@ -144,6 +144,12 @@ static void addShadow(NSImageView *__unsafe_unretained
imageView)
imageView.shadow = buttonShadow;
}
+@interface VLCLibraryWindow ()
+
+@property BOOL presentLoadingOverlayOnVideoPlaybackHide;
+
+@end
+
@implementation VLCLibraryWindow
- (void)awakeFromNib
@@ -806,12 +812,19 @@ static void addShadow(NSImageView *__unsafe_unretained
imageView)
[self showControlsBarImmediately];
[self updateArtworkButtonEnabledState];
self.splitViewController.multifunctionSidebarViewController.mainVideoModeEnabled
= NO;
+
+ if (self.presentLoadingOverlayOnVideoPlaybackHide) {
+ [self showLoadingOverlay];
+ }
}
- (void)showLoadingOverlay
{
if ([self.libraryTargetView.subviews
containsObject:self.loadingOverlayView]) {
return;
+ } else if ([self.libraryTargetView.subviews
containsObject:self.videoViewController.view]) {
+ self.presentLoadingOverlayOnVideoPlaybackHide = YES;
+ return;
}
self.loadingOverlayView.wantsLayer = YES;
@@ -831,6 +844,8 @@ static void addShadow(NSImageView *__unsafe_unretained
imageView)
- (void)hideLoadingOverlay
{
+ self.presentLoadingOverlayOnVideoPlaybackHide = NO;
+
if (![self.libraryTargetView.subviews
containsObject:self.loadingOverlayView]) {
return;
}
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/compare/fa60a909932d5b9ff654233b0632737479fa94fe...9d2479c201f11beefc0f4ce802ee451ff26075e1
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/compare/fa60a909932d5b9ff654233b0632737479fa94fe...9d2479c201f11beefc0f4ce802ee451ff26075e1
You're receiving this email because of your account on code.videolan.org.
VideoLAN code repository instance_______________________________________________
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits
