[vlc-commits] [Git][videolan/vlc][master] 3 commits: macosx: Correctly apply self as delegate in VLCVideoWindowCommon

[@fkuehne]

Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
77178e13 by Claudio Cambra at 2025-08-19T17:44:49+00:00
macosx: Correctly apply self as delegate in VLCVideoWindowCommon

This is expected to be the case. Don't know how we missed this being broken

Signed-off-by: Claudio Cambra <develo...@claudiocambra.com>

- - - - -
55bb0e45 by Claudio Cambra at 2025-08-19T17:44:49+00:00
macosx: Fix check for video view active in library window

Stops the small control bar being opened in main video view mode

Signed-off-by: Claudio Cambra <develo...@claudiocambra.com>

- - - - -
24fb9d58 by Claudio Cambra at 2025-08-19T17:44:49+00:00
macosx: Hide the playqueue sidebar when using native fullscreen

Signed-off-by: Claudio Cambra <develo...@claudiocambra.com>

- - - - -


2 changed files:

- modules/gui/macosx/library/VLCLibraryWindow.m
- modules/gui/macosx/windows/video/VLCVideoWindowCommon.m


Changes:

=====================================
modules/gui/macosx/library/VLCLibraryWindow.m
=====================================
@@ -710,15 +710,19 @@ static void addShadow(NSImageView *__unsafe_unretained 
imageView)
 {
     [super windowWillEnterFullScreen:notification];
 
-    if (!self.videoViewController.view.hidden) {
+    if (self.splitViewController.mainVideoModeEnabled) {
         [self hideControlsBar];
     }
+
+    if (self.splitViewController.mainVideoModeEnabled) {
+        self.splitViewController.multifunctionSidebarItem.animator.collapsed = 
YES;
+    }
 }
 
 - (void)windowDidEnterFullScreen:(NSNotification *)notification
 {
     [super windowDidEnterFullScreen:notification];
-    if (!self.videoViewController.view.hidden) {
+    if (!self.splitViewController.mainVideoModeEnabled) {
         [self showControlsBar];
     }
 }


=====================================
modules/gui/macosx/windows/video/VLCVideoWindowCommon.m
=====================================
@@ -110,6 +110,8 @@ NSString *VLCWindowShouldShowController = 
@"VLCWindowShouldShowController";
         _videoViewController = [[VLCMainVideoViewController alloc] init];
     }
 
+    self.delegate = self;
+
     NSNotificationCenter *notificationCenter = 
NSNotificationCenter.defaultCenter;
     [notificationCenter addObserver:self
                            selector:@selector(mediaMetadataChanged:)



View it on GitLab: 
https://code.videolan.org/videolan/vlc/-/compare/1aeb1d472f325b4af5c529314f69f969d1dd7075...24fb9d58445fc8300f87f22be8391fb3a06a9452

-- 
View it on GitLab: 
https://code.videolan.org/videolan/vlc/-/compare/1aeb1d472f325b4af5c529314f69f969d1dd7075...24fb9d58445fc8300f87f22be8391fb3a06a9452
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance
_______________________________________________
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits