Steve Lhomme pushed to branch master at VideoLAN / VLC
Commits:
5f0238f9 by Thomas Guillem at 2026-02-05T06:20:01+00:00
test: player: titles: fix spurious fail
```
test_src_player_titles: ../../../test/src/player/common.h:924:
test_end_prestop_length: Assertion `ctx->params.length ==
vlc_player_GetLength(player)' failed.
```
The test playback duration is very small. Therefore the player might be
stopped or playing at the end of the test. If stopped, player does not
have an input_thread_t and return VLC_TICK_INVALID from
vlc_player_GetLength().
This test is mainly checking titles, so it's ok to not call test_prestop
here.
Maybe, we could keep the input_thread_t alive when stopped, to allow
users getting previous values, but that won't be possible if a media is
scheduled next...
Fixes #29581
- - - - -
1 changed file:
- test/src/player/titles.c
Changes:
=====================================
test/src/player/titles.c
=====================================
@@ -64,7 +64,6 @@ test_titles(struct ctx *ctx, bool null_names)
assert(VEC_LAST(vec).title_idx == 4);
}
- test_prestop(ctx);
wait_state(ctx, VLC_PLAYER_STATE_STOPPED);
assert_normal_state(ctx);
test_end(ctx);
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/5f0238f9640e1d685607c175498b44d0c58ea375
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/commit/5f0238f9640e1d685607c175498b44d0c58ea375
You're receiving this email because of your account on code.videolan.org.
VideoLAN code repository instance_______________________________________________
vlc-commits mailing list
[email protected]
https://mailman.videolan.org/listinfo/vlc-commits
