Steve Lhomme pushed to branch master at VideoLAN / VLC
Commits:
477ab6bd by Fatih Uzunoglu at 2026-02-05T20:29:35+00:00
qml: fix fallback source is not used if artwork is undefined/null in `DragItem`
If artwork is undefined/null, fallback is not used because the mechanism that
switches to the fallback source is activated when the status becomes
`Image.Error`. In undefined/null case, the source ends up being an empty string,
which makes the status `Image.Null`, rather than `Image.Error`.
Currently we are not additionally checking if the address is available but
empty.
- - - - -
898cfc64 by Fatih Uzunoglu at 2026-02-05T20:29:35+00:00
qml: use default cover if fallback is null/undefined in `DragItem`
This is the worst case scenario, when both artwork and fallback
are undefined/null.
- - - - -
1 changed file:
- modules/gui/qt/widgets/qml/DragItem.qml
Changes:
=====================================
modules/gui/qt/widgets/qml/DragItem.qml
=====================================
@@ -506,7 +506,7 @@ Item {
width: coverSize
height: coverSize
radius: coverRepeater.count > 1 ? dragItem.coverSize : 0.0
- source: modelData.artwork ?? ""
+ source: modelData.artwork ?? modelData.fallback ??
dragItem.defaultCover
sourceSize: dragItem.imageSourceSize ?? Qt.size(width * eDPR,
height * eDPR)
textureProviderItem: modelData?.textureProvider ?? null
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/compare/6772512faedd6c2c362f0767981346308c963b7f...898cfc64dea03c8f836194c15b57181989718a28
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/compare/6772512faedd6c2c362f0767981346308c963b7f...898cfc64dea03c8f836194c15b57181989718a28
You're receiving this email because of your account on code.videolan.org.
VideoLAN code repository instance_______________________________________________
vlc-commits mailing list
[email protected]
https://mailman.videolan.org/listinfo/vlc-commits
