Steve Lhomme pushed to branch master at VideoLAN / VLC
Commits:
e2936b7d by Ahmed Sobhy at 2026-02-13T10:59:30+00:00
fix: add menubar hover, focus, and pressed highlights
- - - - -
2a9d9cab by Ahmed Sobhy at 2026-02-13T10:59:30+00:00
fix: update menubar highlight colors to improve visibility in light mode
- - - - -
3 changed files:
- modules/gui/qt/style/systempalette.cpp
- modules/gui/qt/style/systempalette.hpp
- modules/gui/qt/style/systempalettethemeprovider.cpp
Changes:
=====================================
modules/gui/qt/style/systempalette.cpp
=====================================
@@ -531,8 +531,8 @@ void SystemPalette::makeLightPalette()
{
C::ColorSet CS = C::MenuBar;
setColor(CS, C::Bg, C::Primary, C::Normal, setColorAlpha(lightGrey300,
0.0));
- setColor(CS, C::Bg, C::Primary, C::Focused, lightGrey300);
- setColor(CS, C::Bg, C::Primary, C::Hovered, lightGrey300);
+ setColor(CS, C::Bg, C::Primary, C::Focused, lightGrey700);
+ setColor(CS, C::Bg, C::Primary, C::Hovered, lightGrey700);
setColor(CS, C::Fg, C::Primary, C::Normal, Qt::black);
setColor(CS, C::Fg, C::Primary, C::Disabled, setColorAlpha(Qt::black,
0.2));
}
=====================================
modules/gui/qt/style/systempalette.hpp
=====================================
@@ -130,6 +130,7 @@ public:
COLOR_DEFINITION(lightGrey400, "#EDEDED");
COLOR_DEFINITION(lightGrey500, "#E9E9E9");
COLOR_DEFINITION(lightGrey600, "#E5E5E5");
+ COLOR_DEFINITION(lightGrey700, "#E0E0E0");
COLOR_DEFINITION(red500, "#FF0000");
=====================================
modules/gui/qt/style/systempalettethemeprovider.cpp
=====================================
@@ -226,7 +226,16 @@ static int updatePalette(vlc_qt_theme_provider_t* obj)
setQtColorSetBg(obj, CS, VQTC_NAME_PRIMARY, QPalette::Window);
setQtColorSetFg(obj, CS, VQTC_NAME_PRIMARY, QPalette::WindowText);
+ QColor hightlightPressed = sys->m_isDark ? hightlight.lighter(120) :
hightlight.darker(110);
+
setQtColor(obj, CS, VQTC_SECTION_BG, VQTC_NAME_PRIMARY,
VQTC_STATE_NORMAL, Qt::transparent);
+ setQtColor(obj, CS, VQTC_SECTION_BG, VQTC_NAME_PRIMARY,
VQTC_STATE_HOVERED, hightlight);
+ setQtColor(obj, CS, VQTC_SECTION_BG, VQTC_NAME_PRIMARY,
VQTC_STATE_FOCUSED, hightlight);
+ setQtColor(obj, CS, VQTC_SECTION_BG, VQTC_NAME_PRIMARY,
VQTC_STATE_PRESSED, hightlightPressed);
+
+ setQtColor(obj, CS, VQTC_SECTION_FG, VQTC_NAME_PRIMARY,
VQTC_STATE_HOVERED, textOnHightlight);
+ setQtColor(obj, CS, VQTC_SECTION_FG, VQTC_NAME_PRIMARY,
VQTC_STATE_FOCUSED, textOnHightlight);
+ setQtColor(obj, CS, VQTC_SECTION_FG, VQTC_NAME_PRIMARY,
VQTC_STATE_PRESSED, textOnHightlight);
}
//tool button
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/compare/8f3f83837a09241b0af91fcb8229bb1e43f48b52...2a9d9cab9fcbc17a58bd39ab8878b4c9e44a2411
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/compare/8f3f83837a09241b0af91fcb8229bb1e43f48b52...2a9d9cab9fcbc17a58bd39ab8878b4c9e44a2411
You're receiving this email because of your account on code.videolan.org.
VideoLAN code repository instance_______________________________________________
vlc-commits mailing list
[email protected]
https://mailman.videolan.org/listinfo/vlc-commits
