Felix Paul Kühne pushed to branch master at VideoLAN / VLC
Commits:
79cb0b29 by Claudio Cambra at 2026-02-27T06:20:56+01:00
macosx: Do not display "all favorites" section within favorites library if
there is only one favorites type present
Signed-off-by: Claudio Cambra <[email protected]>
- - - - -
aed1ca0c by Claudio Cambra at 2026-02-27T06:20:56+01:00
macosx: Prevent empty selection in favorites group selection table view
Signed-off-by: Claudio Cambra <[email protected]>
- - - - -
2 changed files:
- modules/gui/macosx/library/favorites-library/VLCLibraryFavoritesDataSource.m
-
modules/gui/macosx/library/favorites-library/VLCLibraryFavoritesViewController.m
Changes:
=====================================
modules/gui/macosx/library/favorites-library/VLCLibraryFavoritesDataSource.m
=====================================
@@ -163,14 +163,16 @@ NSString * const
VLCLibraryFavoritesDataSourceDisplayedCollectionChangedNotifica
- (void)updateVisibleSectionMapping
{
NSMutableArray<NSNumber *> * const visibleSections = [NSMutableArray
array];
-
- for (NSUInteger i = 0; i < VLCLibraryFavoritesSectionCount; i++) {
+ for (NSUInteger i = 1; i < VLCLibraryFavoritesSectionCount; i++) {
NSArray * const sectionArray = [self arrayForSection:i];
if (sectionArray.count > 0) {
[visibleSections addObject:@(i)];
}
}
-
+ if (visibleSections.count > 1) {
+ [visibleSections
insertObject:@(VLCLibraryFavoritesSectionAllFavorites) atIndex:0];
+ }
+
_visibleSectionMapping = [visibleSections copy];
}
=====================================
modules/gui/macosx/library/favorites-library/VLCLibraryFavoritesViewController.m
=====================================
@@ -145,6 +145,7 @@
forIdentifier:VLCAudioLibraryCellIdentifier];
self.favoritesLibraryGroupsTableView.headerView = nil;
+ self.favoritesLibraryGroupsTableView.allowsEmptySelection = NO;
self.favoritesLibraryGroupsTableView.rowHeight =
VLCLibraryUIUnits.mediumTableViewRowHeight;
self.favoritesLibraryGroupSelectionTableView.rowHeight =
VLCLibraryUIUnits.mediumTableViewRowHeight;
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/compare/f110a2040e7b391414d647de1549568c436de492...aed1ca0c53f78efd70b94294f4441418f6e24f99
--
View it on GitLab:
https://code.videolan.org/videolan/vlc/-/compare/f110a2040e7b391414d647de1549568c436de492...aed1ca0c53f78efd70b94294f4441418f6e24f99
You're receiving this email because of your account on code.videolan.org.
VideoLAN code repository instance_______________________________________________
vlc-commits mailing list
[email protected]
https://mailman.videolan.org/listinfo/vlc-commits
