When running vncserver with the -depth 24 parameter, I noticed some programs
like gaim or wine would show blue instead of red and vice versa. Also I'd see
orange instead of green, brown instead of yellow, etc.
This bug also seems to affect mplayer, though it is not immediately noticable
(I had to hack mplayer in order to get it to a state where it would even
render anything without bailing out.)
This patch fixes the problem. With it, both gaim and wine appear normally.
Still working on the fix for mplayer (which seems to think that pixmaps are in
BGR instead of RGB format). [The hacked mplayer runs fine with this patch btw.]
--
Infinite complexity begets infinite beauty.
Infinite precision begets infinite perfection.
--- vnc/Xvnc/xvnc.cc Wed Apr 5 20:00:51 2006
+++ vnc/Xvnc/xvnc.cc Wed Apr 5 20:06:32 2006
@@ -935,6 +935,12 @@
pvfb->greenBits = 6;
}
+ if (!pvfb->pixelFormatDefined && (pvfb->depth == 24 || pvfb->depth == 32)) {
+ pvfb->pixelFormatDefined = TRUE;
+ pvfb->rgbNotBgr = TRUE;
+ pvfb->blueBits = pvfb->redBits = pvfb->greenBits = 8;
+ }
+
if (pvfb->pixelFormatDefined) {
VisualPtr vis;
for (vis = pScreen->visuals; vis->vid != pScreen->rootVisual; vis++)
_______________________________________________
VNC-List mailing list
[email protected]
To remove yourself from the list visit:
http://www.realvnc.com/mailman/listinfo/vnc-list
