Hello Noriaki-san, I had taken a quick look at your patch file and noticed that the files your patch adds appeared to have our copyright notice, which is entirely reasonable if the files are, as you say, significantly based on one of the existing encodings, but that they don't credit you. I'd recommend adding an equivalent line in addition to our notice, both to ensure that you gain fair credit for your work, and to ensure that people know who to contact if they have comments on the code.
Regards, Wez @ RealVNC Ltd. > >Secondly, you haven't added your own copyright notice to the > files you've > >modified - I don't know whether that's intentional, but I thought I'd > >mention it! > > Thank you for your kindness:) > > Did you say about ZYWRLE[Encoder|Decoder].[cxx|h]? > (zywrletemplate.c has already included our copyright notice.) > > I think that they are almost same with ZRLE[Encoder|Decoder].[cxx|h] > which are your great works. I did only a bit thing. > Other modifications are also trivia:) > > So, though I don't think that they needs to include our > copyright notice, > if you'd so, please copy our copyright notice which is in > zywrletemplate.c(line 2-42) into the below of your copyright notice > of them. > > Thank you, again:) > > Regards, > > --- > Noriaki Yamazaki > Administrator of micro-VNC > > Research & Developement center > Hitachi Systems & Services, Ltd. > _______________________________________________ > VNC-List mailing list > [email protected] > To remove yourself from the list visit: > http://www.realvnc.com/mailman/listinfo/vnc-list _______________________________________________ VNC-List mailing list [email protected] To remove yourself from the list visit: http://www.realvnc.com/mailman/listinfo/vnc-list
