It would be very nice to post the patch to the list, so that we can also get the full-color support. Thanks!
Halton Huo wrote: > James, > > Thanks for your information, with spending time to check difference with > 4.0 and 4.04b code, I make a patch for 4.1 to support full-color now. > > Wonder whether RealVNC will add this patch to next Java Free Edition, if > yes, I'm very happy to offer it. :) > > Cheers, > Halton. > > On Thu, 2007-07-19 at 22:47 +0100, James Weatherall wrote: > >> Hi Halton, >> >> VNC Free Edition viewers for Java have never supported full-colour, so if >> your "4.04b" viewer is doing full-colour then it must have been patched to >> do so by someone, possibly the vino guys. >> >> You can download the source code for VNC Viewer Free Edition for Java >> versions 4.1 and 4.0 from http://www.realvnc.com/download.html, but neither >> support full-colour operation, which is available only in the VNC Enterprise >> Edition viewer for Java at present. >> >> Cheers, >> >> Wez @ RealVNC Ltd >> >> >> >>> -----Original Message----- >>> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] >>> Sent: 19 July 2007 15:47 >>> To: James Weatherall >>> Cc: [email protected] >>> Subject: RE: vncviewer.jar regression from 4.04b to 4.1 >>> >>> James, >>> >>> Actually, I get the 4.04b version from gnome/vino, >>> http://cvs.gnome.org/viewcvs/vino/client/java/vino-client.jar? >>> hideattic=0&rev=1.3&view=log >>> >>> >From the changelog, I saw the maintainer did some fix on TLS thing, >>> nothing related with FullColour. >>> >>> I can not get a 4.04b version from realvnc.com, can you get it and >>> please help me to give a try? >>> >>> NOTE: vino-client.jar is vncviewer.jar >>> >>> Thanks. >>> Halton. >>> >>> On Thu, 2007-07-19 at 10:44 +0100, James Weatherall wrote: >>> >>>> Hi Halton, >>>> >>>> Hmmmm... VNC Viewer Free Edition for Java doesn't support >>>> >>> full-colour at >>> >>>> all, which is why those lines are commented out! Are you >>>> >>> sure that you're >>> >>>> using the standard binaries, and that your 4.04b isn't >>>> >>> something custom with >>> >>>> a full-colour-patch applied? >>>> >>>> VNC Viewer Enterprise Edition for Java supports full-colour >>>> >>> operation on >>> >>>> modern Java run-time environments. >>>> >>>> Cheers, >>>> >>>> Wez @ RealVNC Ltd >>>> >>>> >>>> >>>>> -----Original Message----- >>>>> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] >>>>> Sent: 18 July 2007 08:44 >>>>> To: James Weatherall >>>>> Cc: [email protected] >>>>> Subject: RE: vncviewer.jar regression from 4.04b to 4.1 >>>>> >>>>> Wez, >>>>> >>>>> I debugged the program, even autoSelect is on, and >>>>> >>> kbitsPerSecond > >>> >>>>> 3000, still use low color. >>>>> >>>>> Check the code in Conn.java, found some fullColour code >>>>> >>> are commented >>> >>>>> out. >>>>> >>>>> (1) In function autoSelectFormatAndEncoding >>>>> // if (kbitsPerSecond > 1000) { >>>>> // if (!fullColour) { >>>>> // vlog.info("Throughput "+kbitsPerSecond+ >>>>> // " kbit/s - changing to full colour"); >>>>> // fullColour = true; >>>>> // formatChange = true; >>>>> // } >>>>> // } >>>>> >>>>> (2) In function getOptions >>>>> // if (fullColour != options.fullColour.getState()) >>>>> // formatChange = true; >>>>> >>>>> (3) In function requestNewUpdate >>>>> if (fullColour) { >>>>> //desktop.setPF(fullColourPF); >>>>> } else { >>>>> //desktop.setPF(rfb.PixelFormat(8,6,0,1,3,3,3,4,2,0)); >>>>> } >>>>> >>>>> For (1) and (2), I can clear the comments, and build pass. >>>>> For (3), can >>>>> not clear, for desktop does not have setPF interface. >>>>> >>>>> Is that right place which to fix the problem? Any thoughts here? >>>>> >>>>> Cheers, >>>>> Halton. >>>>> >> _______________________________________________ >> VNC-List mailing list >> [email protected] >> To remove yourself from the list visit: >> http://www.realvnc.com/mailman/listinfo/vnc-list >> > _______________________________________________ > VNC-List mailing list > [email protected] > To remove yourself from the list visit: > http://www.realvnc.com/mailman/listinfo/vnc-list _______________________________________________ VNC-List mailing list [email protected] To remove yourself from the list visit: http://www.realvnc.com/mailman/listinfo/vnc-list
