Thanks for the quick response,

Please have a look at your change: 
https://gerrit.fd.io/r/#/c/3345/17/test/test_lb.py

Really the issue is that you uncommented checkCapture in all v6 related 
scenarios.
checkCapture should only be executed for v4 in gre4.

It should work if you just comment these lines again.

- Pierre


> Le 8 nov. 2016 à 17:49, Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at 
> Cisco) <ksek...@cisco.com> a écrit :
> 
> Hi Pierre,
> 
> I've enabled the tests and remove the checkes from the ipv6 branch in
> checkCapture as suggested.
> 
> Now I still see failures, even a vpp crash.
> 
> Please see the attached diff and let me know if I need to do something
> else.
> 
> Attached also the output of the test case..
> 
> Thanks,
> Klement
> 
> On Tue, Nov 08, 2016 at 04:16:18PM +0000, Pierre Pfister (ppfister) wrote:
>> Right.
>> 
>> Klement Sekera was kindly trying to make testing with IPv6 and GRE6 work (It 
>> was partially tested, but there are issues with scapy).
>> Tests are failing because he enabled those tests.
>> I will suggest on the gerrit patch that he rolls-back to the previous test 
>> situation.
>> 
>> - Pierre
>> 
>> 
>>> Le 8 nov. 2016 à 16:37, Maciek Konstantynowicz (mkonstan) 
>>> <mkons...@cisco.com> a écrit :
>>> 
>>> Oups… Agree. I know someone was working on it.. but it’s still failing.. 
>>> And I don’t know how much work to make it stop doing so..
>>> If you could help that would be great.
>>> 
>>> $ git blame test/test_lb.py
>>> 
>>> -Maciek
>>> 
>>>> On 8 Nov 2016, at 15:23, Pierre Pfister (ppfister) <ppfis...@cisco.com> 
>>>> wrote:
>>>> 
>>>> Hello Maciek,
>>>> 
>>>> Do you know what is going wrong with the LB test case ?
>>>> Nobody bothered to tell me the test was failing.
>>>> It would be cool to have a chance to fix it rather than just disabling it.
>>>> 
>>>> Thanks,
>>>> 
>>>> - Pierre
>>>> 
>>>> 
>>>> 
>>>>> Le 8 nov. 2016 à 15:57, Maciek Konstantynowicz (mkonstan) 
>>>>> <mkons...@cisco.com> a écrit :
>>>>> 
>>>>> Hi,
>>>>> 
>>>>> Following from recent discussions on weekly VPP call, IMV the test 
>>>>> framework and 
>>>>> tests in master branch are ready to be used regularly on a per patch 
>>>>> basis.
>>>>> 
>>>>> Hence I propose someone to create a vpp-test-verify* job(s) to do exactly 
>>>>> that.
>>>>> Ed, could you do this or assist some other volunteer to do this?
>>>>> For ubuntu1404, ubuntu1604, centos7, etc.
>>>>> 
>>>>> The only failing test due to unfinished port to somewhat refactored test 
>>>>> framework is test_lb.py,
>>>>> and Klement just pushed a patch that will skip this test: 
>>>>> https://gerrit.fd.io/r/#/c/3726/
>>>>> 
>>>>> Thoughts?
>>>>> 
>>>>> -Maciek
>>>>> 
>>>>> P.S. Current tests in vpp master branch are: 
>>>>> $ ls test
>>>>> doc            log.py         scapy_handlers   test_ip6.pyc   
>>>>> test_l2xc.py   test_mpls.pyc   vpp_interface.py       vpp_pg_interface.pyc
>>>>> framework.py   log.pyc        template_bd.py   test_ip.py     
>>>>> test_l2xc.pyc  test_vxlan.py   vpp_interface.pyc      vpp_sub_interface.py
>>>>> framework.pyc  Makefile       template_bd.pyc  test_ip.pyc    test_lb.py  
>>>>>    test_vxlan.pyc  vpp_papi_provider.py   vpp_sub_interface.pyc
>>>>> hook.py        run_tests.py   test_infra.md    test_l2bd.py   test_lb.pyc 
>>>>>    util.py         vpp_papi_provider.pyc
>>>>> hook.pyc       run_tests.pyc  test_ip6.py      test_l2bd.pyc  
>>>>> test_mpls.py   util.pyc        vpp_pg_interface.py
>>>>> 
>>>>> $ make test
>>>>> <skipped…>
>>>>> ======================================================================
>>>>> IPv6 Test Case
>>>>> ======================================================================
>>>>> IPv6 FIB test                                               OK
>>>>> ======================================================================
>>>>> MPLS Test Case
>>>>> ======================================================================
>>>>> MPLS V4 Explicit NULL test                                  OK
>>>>> MPLS V6 Explicit NULL test                                  OK
>>>>> ======================================================================
>>>>> IPv4 Test Case
>>>>> ======================================================================
>>>>> IPv4 FIB test                                               OK
>>>>> ======================================================================
>>>>> L2XC Test Case
>>>>> ======================================================================
>>>>> L2XC test                                                   OK
>>>>> ======================================================================
>>>>> VXLAN Test Case
>>>>> ======================================================================
>>>>> Decapsulation test                                          OK
>>>>> Encapsulation test                                          OK
>>>>> ======================================================================
>>>>> L2BD Test Case
>>>>> ======================================================================
>>>>> L2BD MAC learning test                                      OK
>>>>> _______________________________________________
>>>>> vpp-dev mailing list
>>>>> vpp-dev@lists.fd.io
>>>>> https://lists.fd.io/mailman/listinfo/vpp-dev
>>> 
>> 
>> _______________________________________________
>> vpp-dev mailing list
>> vpp-dev@lists.fd.io
>> https://lists.fd.io/mailman/listinfo/vpp-dev
> <test.diff><test_fail.txt>

_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev
  • [vpp-dev] Cre... Maciek Konstantynowicz (mkonstan)
    • Re: [vpp... Pierre Pfister (ppfister)
      • Re: ... Maciek Konstantynowicz (mkonstan)
        • ... Ed Warnicke
        • ... Pierre Pfister (ppfister)
          • ... Maciek Konstantynowicz (mkonstan)
          • ... Klement Sekera -X (ksekera - PANTHEON TECHNOLOGIES at Cisco)
            • ... Pierre Pfister (ppfister)
              • ... Maciek Konstantynowicz (mkonstan)
    • Re: [vpp... Ed Warnicke

Reply via email to