On Thu, Apr 27, 2017 at 12:19 PM, Luke, Chris <chris_l...@comcast.com> wrote:
> It looks, to me, like someone fixed a problem in the wrong place. > > > > I would certainly entertain the patch, especially if it included logic to > make sure mp->hostname doesn’t overrun. Not likely since the DHCP option is > limited to the same size but it’s still good practice. What I am not sure > of is NUL in DHCP hostname strings – I remember reading somewhere it’s > optional, so I suspect that means the TLV length is used to determine the > string length; meaning it might be possible to have a hostname that is 64 > printable characters long. Maybe. > According to my RFC digging, 1 to 63 characters. NUL is not a valid hostname character. HTH, jdl
_______________________________________________ vpp-dev mailing list vpp-dev@lists.fd.io https://lists.fd.io/mailman/listinfo/vpp-dev
