+1

On 8/9/2017 1:49 PM, Luke, Chris wrote:
Yeah, I suspect the API was simple enough back at the beginning that it just 
made sense to do it that way. This message, and presumably others, suffer from 
legacy cruft.

Assuming the downstream consumers are okay with it, I fully support blowing out 
the cruft.

Chris.

-----Original Message-----
From: Neale Ranns (nranns) [mailto:nra...@cisco.com]
Sent: Wednesday, August 9, 2017 13:38
To: Luke, Chris <chris_l...@cable.comcast.com>; vpp-dev@lists.fd.io; csit-
d...@lists.fd.io; honeycomb-...@lists.fd.io
Subject: Re: [csit-dev] API Change: Dedicated SW interface Event


Hi Chris,

I don’t know the history. Convenience probably. In the absence of our
attempt at auto-generating/auto-detecting event-notify pairs, the message
re-use is understandable. I’m just trying to avoid the special cases in those
generators (like-wise with the recent ACL dump addition).

I’ll give it till the end of the week, then press the button if there are no
objections.

Thanks,
neale

-----Original Message-----
From: "Luke, Chris" <chris_l...@comcast.com>
Date: Wednesday, 9 August 2017 at 14:25
To: "Neale Ranns (nranns)" <nra...@cisco.com>, "vpp-dev@lists.fd.io"
<vpp-dev@lists.fd.io>, "csit-...@lists.fd.io" <csit-...@lists.fd.io>,
"honeycomb-...@lists.fd.io" <honeycomb-...@lists.fd.io>
Subject: RE: [csit-dev] API Change: Dedicated SW interface Event

     No specific objection, though I don't think I understand why it was done
this way in the first place. Laziness, perhaps?

     Chris.

     > -----Original Message-----
     > From: csit-dev-boun...@lists.fd.io [mailto:csit-dev-boun...@lists.fd.io]
On
     > Behalf Of Neale Ranns (nranns)
     > Sent: Wednesday, August 9, 2017 8:51
     > To: vpp-dev@lists.fd.io; csit-...@lists.fd.io; honeycomb-...@lists.fd.io
     > Subject: Re: [csit-dev] API Change: Dedicated SW interface Event
     >
     >
     > Hi All,
     >
     > Any objections or support for this proposal?
     >
     > Thanks,
     > neale
     >
     > -----Original Message-----
     > From: <csit-dev-boun...@lists.fd.io> on behalf of "Neale Ranns
(nranns)"
     > <nra...@cisco.com>
     > Date: Monday, 7 August 2017 at 16:02
     > To: "vpp-dev@lists.fd.io" <vpp-dev@lists.fd.io>, "csit-...@lists.fd.io"
<csit-
     > d...@lists.fd.io>, "honeycomb-...@lists.fd.io" <honeycomb-
     > d...@lists.fd.io>
     > Subject: [csit-dev] API Change: Dedicated SW interface Event
     >
     >
     >     Hi All,
     >
     >     I would like to propose the addition of a dedicated SW interface 
event
     > message type rather than overload the set flags request. The over-
loading of
     > types causes problems for the automatic API generation tools.
     >
     >     https://gerrit.fd.io/r/#/c/7925/
     >
     >     regards,
     >     neale
     >
     >
     >     _______________________________________________
     >     csit-dev mailing list
     >     csit-...@lists.fd.io
     >     https://lists.fd.io/mailman/listinfo/csit-dev
     >
     >
     > _______________________________________________
     > csit-dev mailing list
     > csit-...@lists.fd.io
     > https://lists.fd.io/mailman/listinfo/csit-dev


_______________________________________________
csit-dev mailing list
csit-...@lists.fd.io
https://lists.fd.io/mailman/listinfo/csit-dev

_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Reply via email to