Thanks for fixing it Jon!
I'm not sure there is anything much better than that. ;-)

Cheers,
Ole

> On 28 Jan 2018, at 17:28, Jon Loeliger <j...@netgate.com> wrote:
> 
> On Sat, Jan 27, 2018 at 3:37 PM, Jon Loeliger <j...@netgate.com> wrote:
> Folks,
> 
> I have updated to top-of-vpp master, now at commit:
> 
>     commit fc804d9cf1d23a616ea7bce19fc65198aa978e6e
>     Author: Florin Coras <fco...@cisco.com>
>     Date:   Fri Jan 26 01:27:01 2018 -0800
> 
>         Fix session/tcp coverity warnings
> 
> I am trying to build a VPP API outside of the VPP tree.
> It now wants to run this rule:
> 
>     %.api.h: %.api
>           vppapigen --input $^ --output $@
> 
> Which is fine.
> 
> It ends up using the VPP package install of /usr/bin/vppapigen,
> but that in turn wants to use ../share/cpp/C.py.  That however,
> appears not to be installed:
> 
>     Exception: Error importing output plugin: /usr/bin/../share/vpp/C.py, 
> [Errno 2] No such file or directory
> 
> Did I miss a step somewhere?  Or should the RPM bundle that up
> and install it as well now?
> 
> Thanks,
> jdl
> 
> Ole,
> 
> I applied this patch and it appears to work.
> 
> I am relatively certain there is a better patch trying to get out here. :-)
> 
> HTH,
> jdl
> 
> 
> diff --git a/extras/rpm/vpp.spec b/extras/rpm/vpp.spec
> index 532b9a2..830ba4f 100644
> --- a/extras/rpm/vpp.spec
> +++ b/extras/rpm/vpp.spec
> @@ -228,6 +228,9 @@ for i in $(ls 
> %{_mu_build_dir}/../src/vpp-api/java/jvpp/gen/jvppgen/*.py); do
>     install -p -m666 ${i} %{buildroot}%{python2_sitelib}/jvppgen
>  done;
> 
> +install -p -m 644 %{_mu_build_dir}/../src/tools/vppapigen/C.py 
> %{buildroot}/usr/share/vpp
> +install -p -m 644 %{_mu_build_dir}/../src/tools/vppapigen/JSON.py 
> %{buildroot}/usr/share/vpp
> +
>  # sample plugin
>  mkdir -p -m755 %{buildroot}/usr/share/doc/vpp/examples/sample-plugin/sample
>  #for file in $(cd 
> %{_mu_build_dir}/%{_vpp_install_dir}/../../src/examples/sample-plugin && git 
> ls-files .)
> 

Attachment: signature.asc
Description: Message signed with OpenPGP

_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Reply via email to