Hi Jon,
I would welcome such a patch.
/neale
From: Jon Loeliger <j...@netgate.com>
Date: Thursday, 1 February 2018 at 17:18
To: vpp-dev <vpp-dev@lists.fd.io>, "Neale Ranns (nranns)" <nra...@cisco.com>
Subject: Consolidatation of fib_ip_proto() functions?
Neale,
I have need of using a function like fib_ip_proto(), below, in yet another file.
But rather than introduce a 5th copy of the same function, would you
accept a patch that consolidated them all into one static inline in, say,
fib_types.h where the FIB_PROTOCOL_* values are defined?
Thanks,
jdl
static inline fib_protocol_t
fib_ip_proto(bool is_ip6)
{
return (is_ip6) ? FIB_PROTOCOL_IP6 : FIB_PROTOCOL_IP4;
}
jdl@bcc-1 $ git grep fib_ip_proto src/
src/plugins/gtpu/gtpu.c:fib_ip_proto (bool is_ip6)
src/plugins/gtpu/gtpu.c: fib_protocol_t fp = fib_ip_proto (is_ip6);
src/plugins/gtpu/gtpu.c: encap_fib_index = fib_table_find
(fib_ip_proto (ipv6_set), tmp);
src/vnet/geneve/geneve.c:fib_ip_proto (bool is_ip6)
src/vnet/geneve/geneve.c: fib_protocol_t fp = fib_ip_proto (is_ip6);
src/vnet/geneve/geneve.c: encap_fib_index = fib_table_find
(fib_ip_proto (ipv6_set), tmp);
src/vnet/vxlan-gpe/vxlan_gpe.c:fib_ip_proto (bool is_ip6)
src/vnet/vxlan-gpe/vxlan_gpe.c: fib_protocol_t fp = fib_ip_proto (is_ip6);
src/vnet/vxlan/vxlan.c:fib_ip_proto(bool is_ip6)
src/vnet/vxlan/vxlan.c: fib_protocol_t fp = fib_ip_proto(is_ip6);
src/vnet/vxlan/vxlan.c: encap_fib_index = fib_table_find (fib_ip_proto
(ipv6_set), tmp);
_______________________________________________
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev
