Dear Shashi,

Anyone can push a patch. See 
https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code#Pushing

Only committers can merge patches into the code base.

HTH... Dave

From: Shashi Kant Singh <[email protected]>
Sent: Sunday, March 11, 2018 11:06 AM
To: Dave Barach (dbarach) <[email protected]>; [email protected]
Subject: RE: Error in loading sample_plugin.so

Hi Dave

I wanted to know how to push a patch.

I am not a reviewer or committer. Still can I do?

How can I become a reviewer / committer ?

Regards
Shashi


From: [email protected]<mailto:[email protected]> 
[mailto:[email protected]] On Behalf Of Dave Barach
Sent: 13 February 2018 18:34
To: [email protected]<mailto:[email protected]>
Subject: [vpp-dev] Error in loading sample_plugin.so

Dear Shashi,

Defining sample_main fixes the problem. If you feel like it, push a patch 
please.

It seems quite likely that your rebuilt plugin .so didn't end up the plugin 
directory.

Thanks... Dave


Reply via email to