Hi Damjan, guys, Agree with Damjan, We can use new vectorized checksum calculation instead of VPP existing implementation also. For my local GRE tunnel testing case, the code can improve 10% or so throughput on haswell as well. Another patch is submitted as Damjan suggested. using ip_csum in ip4_header_checksum https://gerrit.fd.io/r/13803
Thanks Zhiyong From: vpp-dev@lists.fd.io [mailto:vpp-dev@lists.fd.io] On Behalf Of Damjan Marion via Lists.Fd.Io Sent: Saturday, July 28, 2018 7:39 PM To: Dave Barach <dbar...@cisco.com> Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] Manual patch verify request: gerrit 13769 Is incremental checksum really needed here, or we can just move to new vectorized checksum calculation (already used in ip-input)? -- Damjan On 27 Jul 2018, at 22:17, Dave Barach via Lists.Fd.Io <dbarach=cisco....@lists.fd.io<mailto:dbarach=cisco....@lists.fd.io>> wrote: Thanks very much... Dave From: Tina Tsou <tina.t...@arm.com<mailto:tina.t...@arm.com>> Sent: Friday, July 27, 2018 1:51 PM To: Dave Barach (dbarach) <dbar...@cisco.com<mailto:dbar...@cisco.com>> Cc: Brian Brooks <brian.bro...@arm.com<mailto:brian.bro...@arm.com>>; vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> Subject: Re: Manual patch verify request: gerrit 13769 Dear Dave, Looking into it... Thank you, Tina On Jul 27, 2018, at 7:23 AM, Dave Barach (dbarach) <dbar...@cisco.com<mailto:dbar...@cisco.com>> wrote: Folks, Would it be possible for someone to download and manually verify that https://gerrit.fd.io/r/#/c/13769 is functionally correct, and that the proposed change isn’t a performance disaster on aarch64? Thanks... Dave IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9956): https://lists.fd.io/g/vpp-dev/message/9956 Mute This Topic: https://lists.fd.io/mt/23832194/675642 Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dmar...@me.com<mailto:dmar...@me.com>] -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9969): https://lists.fd.io/g/vpp-dev/message/9969 Mute This Topic: https://lists.fd.io/mt/23832194/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
