Yes, reverting that makes build/test succeed.

$ gcc --version
gcc (Debian 8.2.0-9) 8.2.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


On Fri, Dec 14, 2018 at 12:00 PM Dave Barach (dbarach) <dbar...@cisco.com>
wrote:

> Please revert https://gerrit.fd.io/r/#/c/16429/ and report results.
>
> -----Original Message-----
> From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Stephen
> Hemminger
> Sent: Friday, December 14, 2018 2:58 PM
> To: vpp-dev@lists.fd.io
> Subject: [vpp-dev] string test failing
>
> String tests now failing on Debian testing.
>
> Compiler is catching error before test!
>
> FAILED: plugins/unittest/CMakeFiles/unittest_plugin.dir/string_test.c.o
> ccache /usr/lib/ccache/cc -DHAVE_MEMFD_CREATE -Dunittest_plugin_EXPORTS
> -I/home/shemminger/git/vpp/src -I. -Iinclude
> -I/home/shemminger/git/vpp/src/plugins -Iplugins -march=corei7
> -mtune=corei7-avx -g -O0 -DCLIB_DEBUG -DFORTIFY_SOURCE=2
> -fstack-protector-all -fPIC -Werror -fPIC   -Wno-address-of-packed-member
> -Wall -MD -MT
> plugins/unittest/CMakeFiles/unittest_plugin.dir/string_test.c.o -MF
> plugins/unittest/CMakeFiles/unittest_plugin.dir/string_test.c.o.d -o
> plugins/unittest/CMakeFiles/unittest_plugin.dir/string_test.c.o   -c
> /home/shemminger/git/vpp/src/plugins/unittest/string_test.c
> /home/shemminger/git/vpp/src/plugins/unittest/string_test.c: In function
> ‘test_clib_strncpy’:
> /home/shemminger/git/vpp/src/plugins/unittest/string_test.c:766:3: error:
> ‘strncpy’ output truncated copying 10 bytes from a string of length 41
> [-Werror=stringop-truncation]
>    strncpy (dst, "The price of greatness is responsibility.", 10);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#11617): https://lists.fd.io/g/vpp-dev/message/11617
Mute This Topic: https://lists.fd.io/mt/28756144/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to