// re-adding vpp-dev, Neale, Ole Vratko, thanks for spotting! Spoke with Neale, he confirmed route add/del API changes should be transparent to VAT per his updates in [1]. If you spotted any VatExecutor breakage, then this would need to be fixed before [2] is merged. And as CSIT embarked on VAT to PAPI migration, it makes sense to use the new PAPI syntax for all PAPI L1 keywords listed in [3]. Neale is kind to give here heads-up before merging [2], most likely next week. Cheers, -Maciek
[1] https://gerrit.fd.io/r/#/c/12296/29/src/vat/api_format.c [2] https://gerrit.fd.io/r/#/c/12296/ [3] https://git.fd.io/csit/tree/resources/libraries/python On 28 Feb 2019, at 12:19, Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) via Lists.Fd.Io <vrpolak=cisco....@lists.fd.io<mailto:vrpolak=cisco....@lists.fd.io>> wrote: I see this having a big impact on our tests (breaking VatExecutor, needing to update L1 keywords with PapiExecutor). The change is big, look at .api files. For example, I see ip_add_del_route is being renamed to ip_route_add_del. I believe we should start preparing in advance. Vratko. From: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> On Behalf Of Neale Ranns via Lists.Fd.Io Sent: Thursday, 2019-February-28 09:52 To: Ole Troan <otr...@employees.org<mailto:otr...@employees.org>>; vpp-dev <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> Cc: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] Heads up: API cleanup Hi, In the spirit of this work I’d like to propose a change to the route add/del APIs to make use of the fib_path structure. The fib_path structure, which describes how to deal which the matched packets, is consistent across each of the route types; IP, MPLS, BIER and ABF. By using a fib_path we can also pass more than one path for each route update, which is how most IP unicast protocols would normally operate. It is notably faster to add the route once with multiple paths, than add the route multiple times with one path. https://gerrit.fd.io/r/#/c/12296/ regards, neale De : <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> au nom de Ole Troan <otr...@employees.org<mailto:otr...@employees.org>> Date : lundi 25 février 2019 à 10:02 À : vpp-dev <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> Objet : [vpp-dev] Heads up: API cleanup Apologies in advance. This is going to be painful for everyone using the API. In the neverending saga of cleaning up the APIs and making types more explicit, here are the changes I’d like to get in for 19.04: u32 sw_if_index -> vl_api_interface_index_t u8 ip4_address[4] -> vl_api_ip4_address_t u8 ip6_address[16] -> vl_api_ip6_address_t u8 is_ip6 u8 address[16] -> vl_api_address_t u8 prefix_len u8 prefix[4/16] -> vl_api_ip4_prefix_t / vl_api_ip6_prefix_t / vl_api_prefix_t u8 is_<foo> -> bool u8 name[64] -> string name u8 mac_address[6] -> vl_api_mac_address_t u8 data[0] u32 length -> u8 data[length] The explicit types allow for much better type checking on the client side, as well as automatic mapping into the respective types on the client side. E.g. vl_api_address_t mapping into Python IPAddress object. Best regards, Ole -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#12335): https://lists.fd.io/g/vpp-dev/message/12335 Mute This Topic: https://lists.fd.io/mt/30035998/675192 Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [nra...@cisco.com<mailto:nra...@cisco.com>] -=-=-=-=-=-=-=-=-=-=-=- -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#12385): https://lists.fd.io/g/vpp-dev/message/12385 Mute This Topic: https://lists.fd.io/mt/30035998/870305 Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [vrpo...@cisco.com<mailto:vrpo...@cisco.com>] -=-=-=-=-=-=-=-=-=-=-=- -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#3352): https://lists.fd.io/g/csit-dev/message/3352 Mute This Topic: https://lists.fd.io/mt/30162681/675185 Group Owner: csit-dev+ow...@lists.fd.io<mailto:csit-dev+ow...@lists.fd.io> Unsubscribe: https://lists.fd.io/g/csit-dev/unsub [mkons...@cisco.com<mailto:mkons...@cisco.com>] -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#12404): https://lists.fd.io/g/vpp-dev/message/12404 Mute This Topic: https://lists.fd.io/mt/30173719/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
