Hi John, I tested it after removing the dummy_interface_tx nodes for PPPoE sessions in VPP 19.01 and it works perfectly fine. One node is being created for all PPPoE session.
Thank you soo much for your help. Regards, Abeeha Aqeel From: John Lo (loj) via Lists.Fd.Io Sent: Thursday, April 18, 2019 7:51 PM To: John Lo (loj); Abeeha Aqeel; hongjun...@intel.com; vpp-dev@lists.fd.io Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] VPP PPPoE Plugin Hi Abeeha, I submitted a patch to gerrt.fd.io to remove output nodes for PPPoE. https://gerrit.fd.io/r/#/c/18993/ Would you like to try if it fixes your node index out of range issue? I expect the patch can easily be cherry-picked to 1901. Regards, John From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of John Lo (loj) via Lists.Fd.Io Sent: Wednesday, April 17, 2019 12:06 PM To: Abeeha Aqeel <abeeha.aq...@xflowresearch.com>; hongjun...@intel.com; vpp-dev@lists.fd.io Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] VPP PPPoE Plugin Hi Abeeha, Have you tried the suggestion I made previously in a similar thread to get rid of the dummy_interface_tx nodes for PPPoE sessions? diff --git a/src/plugins/pppoe/pppoe.c b/src/plugins/pppoe/pppoe.c index d73a718..f61926d 100644 --- a/src/plugins/pppoe/pppoe.c +++ b/src/plugins/pppoe/pppoe.c @@ -87,7 +87,7 @@ pppoe_interface_admin_up_down (vnet_main_t * vnm, u32 hw_if_index, u32 flags) VNET_DEVICE_CLASS (pppoe_device_class,static) = { .name = "PPPoE", .format_device_name = format_pppoe_name, - .tx_function = dummy_interface_tx, + // .tx_function = dummy_interface_tx, .admin_up_down_function = pppoe_interface_admin_up_down, }; /* *INDENT-ON* */ I believe this would prevent creation of TX nodes for PPPoE sessions which are not used anyway. Then you should not encounter any problem with node index assert error. If it does work, please submit this patch via gerrit.fd.io so it can be merged upstream. Regards, John From: vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> On Behalf Of Abeeha Aqeel Sent: Wednesday, April 17, 2019 8:20 AM To: hongjun...@intel.com; vpp-dev@lists.fd.io Cc: b...@xflowresearch.com Subject: [vpp-dev] VPP PPPoE Plugin Dear Hongjun, (PFA = Please find attached) Code: Branch: stable/1901 Patch: PFA: stable_1901_patch.txt Configuration: PFA: vpp-startup.conf Steps for setting up: PFA: setup_steps.bash Attempted to make 10,000 connections. Using API calls from control plane application; to create pppoe sessions Final output from control plane before VPP crashed: PFA: no_of_connections.png VPP log-file: PFA:vpp.log Dump from journalctl: PFA: journal_dump.txt As you can see from the journalctl output, the code crashes on the Assertion ‘node_index < 2^14’. And as you can see from the patch file included, we changed the original assertion from ‘less than 2^10’ to ‘less than 2^14’. We did that, because the original assertion crashes VPP way before even 7,000 connections are connected. (Around 400 connections.) Regards, Abeeha Aqeel From: AbduSami bin Khurram Sent: Wednesday, April 17, 2019 2:33 PM To: Abeeha Aqeel Subject: RE: VPP PPPoE Plugin Dear Abeeha, (PFA = Please find attached) Code: Branch: stable/1901 Patch: PFA: stable_1901_patch.txt Configuration: PFA: vpp-startup.conf Steps for setting up: PFA: setup_steps.bash Attempted to make 10,000 connections. Using API calls from control plane application; to create pppoe sessions Final output from control plane before VPP crashed: PFA: no_of_connections.png VPP log-file: PFA:vpp.log Dump from journalctl: PFA: journal_dump.txt As you can see from the journalctl output, the code crashes on the Assertion ‘node_index < 2^14’. And as you can see from the patch file included, we changed the original assertion from ‘less than 2^10’ to ‘less than 2^14’. We did that, because the original assertion crashes VPP way before even 7,000 connections are connected. (Around 400 connections.) Warm Regards, AbduSami bin Khurram Software Design Engineer, xFlow Research Pvt. Ltd. +92-331-5543190 abdusami.khur...@xflowresearch.com www.xflowresearch.com From: Ni, Hongjun Sent: 17 April 2019 13:04 To: Abeeha Aqeel; vpp-dev@lists.fd.io Cc: b...@xflowresearch.com Subject: RE: VPP PPPoE Plugin Hi Aqeel, Could you send out the core dump log when VPP crash with 7000 sessions? Thanks, Hongjun From: Abeeha Aqeel [mailto:abeeha.aq...@xflowresearch.com] Sent: Tuesday, April 16, 2019 8:01 PM To: Ni, Hongjun <hongjun...@intel.com>; vpp-dev@lists.fd.io Cc: b...@xflowresearch.com Subject: VPP PPPoE Plugin Dear Hongjun, I am trying to create 64000 VPP sessions with the VPP Plugin. VPP is being used as the forwarding plane while our control plane separately caters the PPPoE control packets. The VPP is installed on Centos 7 on bare-metal server. The current implementation of the plugin included in VPP Stable 19.01 is allowing only 7000 sessions and VPP crashes afterwards. I tried to add the PPPoE plugin implemented by OpenBRAS (https://gerrit.fd.io/r/#/c/7407/) to the VPP Stable 19.01 ( https://github.com/FDio/vpp.git) with DPDK 18.11.0. VPP built successfully and started as well but the PPPoE plugin did not show in “vppctl show plugins”. Kindly, suggest how to connect 64000 pppoe sessions with VPP. Regards, Abeeha Aqeel
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#12824): https://lists.fd.io/g/vpp-dev/message/12824 Mute This Topic: https://lists.fd.io/mt/31199594/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
