Hi Jon, Yup, it has to match a maintainer “I” entry and yes, that’s where the script is. :-)
Florin > On Jun 17, 2019, at 1:16 PM, Jon Loeliger via Lists.Fd.Io > <jdl=netgate....@lists.fd.io> wrote: > > And now this: > > =============================== ERROR =============================== > Unknown feature 'Consolidate' in commit 'Subject:' line. > Feature must exist in MAINTAINERS file. If this commit intruduces > new feature, then this commit must add new entry into the > MAINTAINERS file. > =============================== ERROR =============================== > Does it just check the first word on the subject line regardless? > What else is being checked? Poorly? > Does it _have_ to match a MAINTAINER I: word? > > Where is this script? Rhetorical. It is here: > extras/scripts/check_commit_msg.sh > > Now I at least know what I am up against. > > jdl > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#13306): https://lists.fd.io/g/vpp-dev/message/13306 > Mute This Topic: https://lists.fd.io/mt/32096793/675152 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [fcoras.li...@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13307): https://lists.fd.io/g/vpp-dev/message/13307 Mute This Topic: https://lists.fd.io/mt/32096793/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
