Fix looks good, modulo a checkstyle failure which I fixed. Will merge when verified.
From: <vpp-dev@lists.fd.io> on behalf of Andreas Schultz <andreas.schu...@travelping.com> Date: Tuesday, June 25, 2019 at 9:27 AM To: Recipient Suppressed <dbar...@cisco.com> Cc: "vpp-dev@lists.fd.io" <vpp-dev@lists.fd.io>, "hagb...@gmail.com" <hagb...@gmail.com>, "winkelmann, holger" <holger.winkelm...@travelping.com>, "gumz, mathias" <mathias.g...@travelping.com> Subject: Re: [vpp-dev] tw_timer_first_expires_in_ticks problem Hi, I've found the problem. Turns out that tw_timer_first_expires_in_ticks gives wrong results for TW timers with multiple wheels. More details and fix in https://gerrit.fd.io/r/#/c/20329/ Regards Andreas Am Mo., 24. Juni 2019 um 16:26 Uhr schrieb Dave Barach (dbarach) <dbar...@cisco.com<mailto:dbar...@cisco.com>>: In real life - aka if you set now = vlib_time_now(vm) - the variable "now" would be the number of f64 seconds since vpp started, not the number of f64 seconds since 1/1/1970. Although you don't show the entire code, it looks like you built it into vpp instead of as a standalone test. In terms of working out what's happening, try random_f64(...) with a fixed seed so that the test sequence is 100% reproducible. Please make sure that you're not accidentally failing to call tw_expire_timers_xxx for an entire second or something like that. Calling tw_timer_expire_timers_xxx less frequently than the stated tick rate guarantees poor behavior. The code shouldn't misbehave in a gross way - if it does, we'll fix it - but there's no reason to expect things to work properly if you violate the laws of physics... HTH... Dave -- Andreas Schultz -- Principal Engineer t: +49 391 819099-224 ------------------------------- enabling your networks ----------------------------- Travelping GmbH Roentgenstraße 13 39108 Magdeburg Germany t: +49 391 819099-0 f: +49 391 819099-299 e: i...@travelping.com<mailto:i...@travelping.com> w: https://www.travelping.com/ Company registration: Amtsgericht Stendal Reg. No.: HRB 10578 Geschaeftsfuehrer: Holger Winkelmann VAT ID: DE236673780
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13365): https://lists.fd.io/g/vpp-dev/message/13365 Mute This Topic: https://lists.fd.io/mt/32192172/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
