Apologies, seems today is not my day with links. Florin
[1] https://github.com/openstack-infra/git-review/tree/master/git_review <https://github.com/openstack-infra/git-review/tree/master/git_review> > On Jul 30, 2019, at 1:51 PM, Florin Coras via Lists.Fd.Io > <fcoras.lists=gmail....@lists.fd.io> wrote: > > Pushed send too soon > > Florin > > [1] /usr/lib/python3/dist-packages/git_review/cmd.py > >> On Jul 30, 2019, at 1:49 PM, Florin Coras via Lists.Fd.Io >> <fcoras.lists=gmail....@lists.fd.io >> <mailto:fcoras.lists=gmail....@lists.fd.io>> wrote: >> >> It seems that this [1] supports the new workflows. Just overwriting >> /usr/lib/python3/dist-packages/git_review/cmd.py seems to do the trick. >> >> I’m sure there must be a cleaner way … >> >> Florin >> >>> On Jul 30, 2019, at 1:20 PM, Vanessa Valderrama >>> <vvalderr...@linuxfoundation.org <mailto:vvalderr...@linuxfoundation.org>> >>> wrote: >>> >>> Changes that will happen with Gerrit: >>> >>> 1) The 'New UI' for Gerrit will become the default UI >>> >>> 2) The Draft work flow is removed and replaced with 'Work in Progress' >>> aka 'WIP' and 'Private' workflows. Unfortunately git-review does not >>> support either of these workflows directly. Utilizing them means either >>> pushing your changes the manual way for either system or pushing them up >>> with git-review and then marking the change via the UI into either of >>> the workflows. >>> >>> >>> To push a private change you may do so as follows: >>> git push origin HEAD:refs/for/master%private >>> >>> To pull it out of private you may do so as follows: >>> git push origin HEAD:refs/for/master%remove-private >>> >>> To push a WIP you may do so as follows: >>> git push origin HEAD:refs/for/master%wip >>> >>> To mark it ready for review you may do so as follows: >>> git push origin HEAD:refs/for/master%ready >>> >>> Once a change is in either private or WIP state it does not switch the >>> change to a ready state until the current state has been removed. >>> >>> In both cases, the state can be set via the UI by selecting the tripple >>> dot menu option on the change and selecting the appropriate option. >>> >>> To remove WIP state press the 'START REVIEW' button. To remove the >>> private state you must do so via the menu. >>> >>> NOTE: We are not moving to Gerrit 3 at this time. That is on the road >>> map but we need to come to the latest 2.x as we have to do various >>> migrations that are only available at the 2.16 level before we can move >>> to Gerrit 3. >>> >>> Thank you, >>> Vanessa >>> -=-=-=-=-=-=-=-=-=-=-=- >>> Links: You receive all messages sent to this group. >>> >>> View/Reply Online (#61): https://lists.fd.io/g/dmm-dev/message/61 >>> <https://lists.fd.io/g/dmm-dev/message/61> >>> Mute This Topic: https://lists.fd.io/mt/32658314/675152 >>> <https://lists.fd.io/mt/32658314/675152> >>> Group Owner: dmm-dev+ow...@lists.fd.io <mailto:dmm-dev+ow...@lists.fd.io> >>> Unsubscribe: https://lists.fd.io/g/dmm-dev/unsub >>> <https://lists.fd.io/g/dmm-dev/unsub> [fcoras.li...@gmail.com >>> <mailto:fcoras.li...@gmail.com>] >>> -=-=-=-=-=-=-=-=-=-=-=- >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> >> View/Reply Online (#13624): https://lists.fd.io/g/vpp-dev/message/13624 >> <https://lists.fd.io/g/vpp-dev/message/13624> >> Mute This Topic: https://lists.fd.io/mt/32658598/675152 >> <https://lists.fd.io/mt/32658598/675152> >> Group Owner: vpp-dev+ow...@lists.fd.io <mailto:vpp-dev+ow...@lists.fd.io> >> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub >> <https://lists.fd.io/g/vpp-dev/unsub> [fcoras.li...@gmail.com >> <mailto:fcoras.li...@gmail.com>] >> -=-=-=-=-=-=-=-=-=-=-=- > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#13625): https://lists.fd.io/g/vpp-dev/message/13625 > Mute This Topic: https://lists.fd.io/mt/32658616/675152 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [fcoras.li...@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13626): https://lists.fd.io/g/vpp-dev/message/13626 Mute This Topic: https://lists.fd.io/mt/32658627/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
