Dear Nitin, Here is my view on this:
- All VPP dependencies should be open source and freely available software, afaik access to Marvell SDK is restricted to NDA customers and that is no go - preferred way to add device driver support in VPP is native one, typically provided as plugin and such driver can be linked to external library if it is open source. We already do that with marvel MUSDK and rdma-core. Nice feature of both libraries is that they provide way to access descriptors directly without metadata conversion into intermediate data structure (e.g. dpdk rte_mbuf). - we are fine to have out-of-tree patches on top of DPDK as long as they are limited to providing new PMD and not altering common dpdk code. - Having separate plugin with own "special" version of DPDK is something I don't like. You should decide either to go with dpdk pmd and extend existing dpdk plugin, or create native driver without dpdk code. Thanks, Damjan > On 19 Aug 2019, at 20:03, Nitin Saxena <[email protected]> wrote: > > Hi Damjan, > > Thanks for comment. libmarvelldpdk is not intended to be a closed source and > is part of Marvell SDK for our customers. Would it be ok to provide patches > against DPDK release (from dpdk.org <http://dpdk.org/>) OR does it need to be > hosted publicly? > > Thanks, > Nitin > From: [email protected] <mailto:[email protected]> <[email protected] > <mailto:[email protected]>> on behalf of Damjan Marion via Lists.Fd.Io > <[email protected] <mailto:[email protected]>> > Sent: Monday, August 19, 2019 9:30 PM > To: Nitin Saxena <[email protected] <mailto:[email protected]>> > Cc: [email protected] <mailto:[email protected]> <[email protected] > <mailto:[email protected]>> > Subject: [EXT] Re: [vpp-dev] Marvell OCTEONTx2 plugin > > External Email > > Dear Nitin, > > Where we can find “libmarvelldpdk”? Google search doesn’t show single > occurrence. > > We don’t support contributions linked to closed source libraries… > > — > Damjan > > > > >> On 19 Aug 2019, at 16:53, Nitin Saxena <[email protected] >> <mailto:[email protected]>> wrote: >> >> Hi, >> >> Following is the link for README.md >> https://gerrit.fd.io/r/#/c/vpp/+/21394/1/src/plugins/octeontx2/README.md >> <https://gerrit.fd.io/r/#/c/vpp/+/21394/1/src/plugins/octeontx2/README.md> >> >> Thanks, >> Nitin >> From: [email protected] <mailto:[email protected]> <[email protected] >> <mailto:[email protected]>> On Behalf Of Nitin Saxena >> Sent: Monday, August 19, 2019 8:21 PM >> To: [email protected] <mailto:[email protected]> >> Cc: Narayana Prasad Raju Athreya <[email protected] >> <mailto:[email protected]>> >> Subject: [EXT] [vpp-dev] Marvell OCTEONTx2 plugin >> >> External Email >> Hi Maintainers, >> >> I have pushed patch for Marvell OCTEON TX2 driver plugin: >> https://gerrit.fd.io/r/#/c/vpp/+/21394/ >> <https://gerrit.fd.io/r/#/c/vpp/+/21394/> >> >> Appreciate your feedback on the patch. >> >> Thanks, >> Nitin >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> >> View/Reply Online (#13786): https://lists.fd.io/g/vpp-dev/message/13786 >> <https://lists.fd.io/g/vpp-dev/message/13786> >> Mute This Topic: https://lists.fd.io/mt/32945036/675642 >> <https://lists.fd.io/mt/32945036/675642> >> Group Owner: [email protected] <mailto:[email protected]> >> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub >> <https://lists.fd.io/g/vpp-dev/unsub> [[email protected] >> <mailto:[email protected]>] >> -=-=-=-=-=-=-=-=-=-=-=- > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#13791): https://lists.fd.io/g/vpp-dev/message/13791 > <https://lists.fd.io/g/vpp-dev/message/13791> > Mute This Topic: https://lists.fd.io/mt/32958379/675642 > <https://lists.fd.io/mt/32958379/675642> > Group Owner: [email protected] <mailto:[email protected]> > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub > <https://lists.fd.io/g/vpp-dev/unsub> [[email protected] > <mailto:[email protected]>] > -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13792): https://lists.fd.io/g/vpp-dev/message/13792 Mute This Topic: https://lists.fd.io/mt/32958934/21656 Group Owner: [email protected] Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
