Elias,
Thanks for the patch -- I just merged it.
Welcome to the VPP community :)
Thanks,
-daw-
On 9/12/2019 5:19 AM, Damjan Marion wrote:
see:
https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code
Section 6....
On 12 Sep 2019, at 11:11, Elias Rudberg <[email protected]
<mailto:[email protected]>> wrote:
OK, now I created a Jira issue about it:
https://jira.fd.io/browse/VPP-1772
I would like to commit and push a fix also, but I'm not sure how to do
that properly. Looking at "git log" it looks like you are using some
special form of commit messages with special "Signed-off-by" and
"Change-Id" parts, I don't know what those mean. Are you using some
tool to generate those commit messages, rather than just doing "git
commit" at the command-line?
Best regards,
Elias
On Wed, 2019-09-11 at 15:03 -0400, Dave Wallace wrote:
Elias,
Please open a Jira Ticket and push a patch with this fix.
BTW, there is a macro [0] that safely adds c-string termination to a
vector which I would recommend using for your fix (2).
Thanks,
-daw-
[0]
https://docs.fd.io/vpp/19.08/db/d65/vec_8h.html#a2bc43313bc727b5453c3e5d7cc57a464
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#13969): https://lists.fd.io/g/vpp-dev/message/13969
Mute This Topic: https://lists.fd.io/mt/34104878/675642
Group Owner: [email protected]
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#13974): https://lists.fd.io/g/vpp-dev/message/13974
Mute This Topic: https://lists.fd.io/mt/34104878/21656
Group Owner: [email protected]
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
