I rebased one of my failing patches, and the API crc check passed. Thanks for your help!
Dave 08:54:51 +++ export PYTHONPATH=/w/workspace/vpp-csit-verify-api-crc-master/csit 08:54:51 +++ PYTHONPATH=/w/workspace/vpp-csit-verify-api-crc-master/csit 08:54:51 +++ make json-api-files 08:54:51 /w/workspace/vpp-csit-verify-api-crc-master/src/tools/vppapigen/generate_json.py 08:55:03 Searching '/w/workspace/vpp-csit-verify-api-crc-master/src' for .api files. 08:55:03 json files written to: /w/workspace/vpp-csit-verify-api-crc-master/build-root/install-vpp-native/vpp/share/vpp/api/. 08:55:03 +++ python csit/resources/tools/integrated/check_crc.py 08:55:04 08:55:04 @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ 08:55:04 08:55:04 VPP CSIT API CHECK PASS! 08:55:04 08:55:04 @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ -----Original Message----- From: Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) <vrpo...@cisco.com> Sent: Friday, September 20, 2019 8:47 AM To: Dave Barach (dbarach) <dbar...@cisco.com>; Benoit Ganne (bganne) <bga...@cisco.com>; Maciek Konstantynowicz (mkonstan) <mkons...@cisco.com>; Andrew Yourtchenko (ayourtch) <ayour...@cisco.com>; Ed Kern (ejk) <e...@cisco.com>; Dave Wallace -X (dwallace - NETPACE INC at Cisco) <dwall...@cisco.com> Cc: csit-...@lists.fd.io; vpp-dev@lists.fd.io Subject: RE: [csit-dev] API check failure Fixed. Short report: https://lists.fd.io/g/vpp-api-dev/message/34 Longer discussion on how to prevent similar things from happening in future: #csit-dev channel on FD.io slack. We will update the flag day document when we conclude the discussion. Vratko. -----Original Message----- From: Dave Barach (dbarach) <dbar...@cisco.com> Sent: Friday, September 20, 2019 1:41 PM To: Benoit Ganne (bganne) <bga...@cisco.com>; Maciek Konstantynowicz (mkonstan) <mkons...@cisco.com>; Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) <vrpo...@cisco.com>; Andrew Yourtchenko (ayourtch) <ayour...@cisco.com>; Ed Kern (ejk) <e...@cisco.com>; Dave Wallace -X (dwallace - NETPACE INC at Cisco) <dwall...@cisco.com> Cc: csit-...@lists.fd.io; vpp-dev@lists.fd.io Subject: RE: [csit-dev] API check failure Importance: High Yes. Since folks have been unable to debug the problem so far, we need to disable voting on the API CRC checker job. Ed Kern [or anyone with appropriate access rights!]: please do that immediately, and send email to vpp-dev@lists.fd.io so folks can "recheck" patches which failed for no good reason. We've built up a backlog of patches to recheck, and it's reached the point where we need to get things moving again. Thanks... Dave -----Original Message----- From: Benoit Ganne (bganne) <bga...@cisco.com> Sent: Friday, September 20, 2019 5:58 AM To: Maciek Konstantynowicz (mkonstan) <mkons...@cisco.com>; Dave Barach (dbarach) <dbar...@cisco.com>; Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) <vrpo...@cisco.com> Cc: csit-...@lists.fd.io Subject: RE: [csit-dev] API check failure I am facing the same issue: https://gerrit.fd.io/r/c/vpp/+/22103 I rebased on top of https://gerrit.fd.io/r/c/vpp/+/21458/7 but it is complaining about this: Dir check found incompatible API CRCs: { "cop_interface_enable_disable":"0x5501adee", "cop_whitelist_enable_disable":"0xdebe13ea" } RuntimeError('Dir check found incompatible API CRCs:\n{\n "cop_interface_enable_disable":"0x5501adee",\n "cop_whitelist_enable_disable":"0xdebe13ea"\n}',) Is there anything else to be done? ben > -----Original Message----- > From: csit-...@lists.fd.io <csit-...@lists.fd.io> On Behalf Of Maciek > Konstantynowicz (mkonstan) via Lists.Fd.Io > Sent: jeudi 19 septembre 2019 21:59 > To: Dave Barach (dbarach) <dbar...@cisco.com>; Vratko Polak -X > (vrpolak - PANTHEON TECHNOLOGIES at Cisco) <vrpo...@cisco.com> > Cc: csit-...@lists.fd.io > Subject: Re: [csit-dev] API check failure > > + Vratko > > > > On 19 Sep 2019, at 18:50, Dave Barach (dbarach) <dbar...@cisco.com > <mailto:dbar...@cisco.com> > wrote: > > https://gerrit.fd.io/r/c/vpp/+/22150/2/src/vnet/interface_cli.c > > is a one-line fix which changes > > if (pp->pcap_enable == 0) > > to > > if (pp->pcap_enable) > > in one place. Clearly no API change, but unfortunately resulted in the > CSIT API check failure shown below. The patch appears not to need a > rebase. > > Mind taking a look? > > Thanks... Dave > > > 11:42:05 RuntimeError: > 11:42:05 Dir check found incompatible API CRCs: > 11:42:05 { > 11:42:05 "cop_interface_enable_disable":"0x69d24598", > 11:42:05 "cop_whitelist_enable_disable":"0x8bb8f6dc" > 11:42:05 } > 11:42:05 RuntimeError('Dir check found incompatible API CRCs:\n{\n > "cop_interface_enable_disable":"0x69d24598",\n > "cop_whitelist_enable_disable":"0x8bb8f6dc"\n}',) > 11:42:05 > 11:42:05 > @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ > 11:42:05 > 11:42:05 VPP CSIT API CHECK FAIL! > 11:42:05 > 11:42:05 This means the patch under test has missing messages, > 11:42:05 or messages with unexpected CRCs compared to what CSIT needs. > 11:42:05 Either this Change and/or its ancestors were editing .api > files, > 11:42:05 or your chain is not rebased upon the recent enough VPP > codebase. > 11:42:05 > 11:42:05 Please rebase the patch to see if that fixes the problem. > 11:42:05 If that fails email csit-...@lists.fd.io <mailto:csit- > d...@lists.fd.io> for a new > 11:42:05 operational branch supporting the api changes. > 11:42:05 > 11:42:05 > @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ > 11:42:05 Build step 'Execute shell' marked build as failure > 11:42:05 $ ssh-agent -k > 11:42:05 unset SSH_AUTH_SOCK; > 11:42:05 unset SSH_AGENT_PID; > 11:42:05 echo Agent pid 67 killed; > 11:42:05 [ssh-agent] Stopped. > 11:42:07 [PostBuildScript] - Executing post build scripts. > 11:42:07 [vpp-csit-verify-api-crc-master] $ /bin/bash > /tmp/jenkins13211504889301879538.sh > 11:42:07 Build logs: <a href="https://logs.fd.io/production/vex-yul- > rot-jenkins-1/vpp-csit-verify-api-crc- > master/755">https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-cs > it- > verify-api-crc-master/755</a> >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14035): https://lists.fd.io/g/vpp-dev/message/14035 Mute This Topic: https://lists.fd.io/mt/34229401/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
