I just tried make test and make test-debug on 23417 in my environment - the only tests I had the problem In my environment with are the test suites with long-running CLI commands, so I presume this means without the extended tests it should pass the verification.
As for the extended tests - they *never* were executed in the CI environment, so again - worth doing it in the separate change request, imo. --a > On 27 Nov 2019, at 22:18, Andrew Yourtchenko via Lists.Fd.Io > <[email protected]> wrote: > > (Thinking a bit more of this - assuming the aim with the extended tests was > to make the scapy upgrade a single change - I would still maintain, that it > would make more sense to first port the standard tests, and then separately > look at extended tests - this way it will be much easier, since instead of a > single large chunk of work it will be two small ones) > > --a > >> On 27 Nov 2019, at 22:09, Andrew Yourtchenko via Lists.Fd.Io >> <[email protected]> wrote: >> >> Paul, >> >> I looked at both - to me they appear to deal with collateral damage >> from undiagnosed root causes, so unfortunately I could not plus-vote >> them. >> >> The 23417 itself, as it appears, someone added EXTENDED_TESTS=1, which >> is known to have problems, the extended tests simply do not pass in >> the CI environment. >> >> Do you know why was it added and how is it related to scapy version >> update, which 23417 is aiming for ? >> >> The extended tests are *known* not to pass, and enabling that flag in >> a work-in-progress is a recipe for headaches. Please have her remove >> the "EXTENDED_TESTS" and then let's troubleshoot the root causes of >> the issues that are happening. >> >> --a >> >> >>>> On 11/27/19, Paul Vinciguerra <[email protected]> wrote: >>> Can I nudge someone here to please review: >>> https://gerrit.fd.io/r/c/vpp/+/23490 https://gerrit.fd.io/r/c/vpp/+/23521 >>> >>> They were added some 10 days ago to help Sunitha along with her failing >>> job. >>> https://gerrit.fd.io/r/c/vpp/+/23417 >>> >>> Latest logs here: >>> https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-verify-master-ubuntu1804/565/console-timestamp.log.gz >>> >>> Thanks! >>> >>> Paul >>> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> >> View/Reply Online (#14719): https://lists.fd.io/g/vpp-dev/message/14719 >> Mute This Topic: https://lists.fd.io/mt/62577574/675608 >> Group Owner: [email protected] >> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [[email protected]] >> -=-=-=-=-=-=-=-=-=-=-=- > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#14720): https://lists.fd.io/g/vpp-dev/message/14720 > Mute This Topic: https://lists.fd.io/mt/62577574/675608 > Group Owner: [email protected] > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [[email protected]] > -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14721): https://lists.fd.io/g/vpp-dev/message/14721 Mute This Topic: https://lists.fd.io/mt/62577574/21656 Group Owner: [email protected] Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
