Hi Aleksander,

> 3) vpp_papi: correct unformat ip address for ip_address_dump, ip_route_dump, 
> etc (unformat-api-prefix.patch)

would you mind elaborating why you want the Python representation of an IP 
prefix to be a dictionary of address and length as opposed to an 
IPv6Network/IPv4Network object?

--- a/src/vpp-api/python/vpp_papi/vpp_format.py 2019-10-30 11:50:40.676813774 
+0300
+++ b/src/vpp-api/python/vpp_papi/vpp_format.py 2019-12-26 16:10:54.014344478 
+0300
@@ -182,17 +182,11 @@
 
 def unformat_api_prefix_t(o):
     if o.address.af == 1:
-        return ipaddress.IPv6Network((o.address.un.ip6, o.len), False)
+        return {'address': ipaddress.IPv6Address(o.address.un.ip6), 'len': 
o.len}
     if o.address.af == 0:
-        return ipaddress.IPv4Network((o.address.un.ip4, o.len), False)
+        return {'address': ipaddress.IPv4Address(o.address.un.ip4), 'len': 
o.len}
     raise ValueError('Unknown address family {}'.format(o))
 
-    if isinstance(o.address, ipaddress.IPv4Address):
-        return ipaddress.IPv4Network((o.address, o.len), False)
-    if isinstance(o.address, ipaddress.IPv6Address):
-        return ipaddress.IPv6Network((o.address, o.len), False)
-    raise ValueError('Unknown instance {}', format(o))
-
 def unformat_api_address_with_prefix_t(o):
     if o.address.af == 1:
         return ipaddress.IPv6Interface((o.address.un.ip6, o.len))


Best regards,
Ole
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#15137): https://lists.fd.io/g/vpp-dev/message/15137
Mute This Topic: https://lists.fd.io/mt/69665543/21656
Mute #vpp: https://lists.fd.io/mk?hashtag=vpp&subid=1480452
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to